Should unit-test coverage be checked for DBT sources?

[pvij-clear]

Running dbt-coverage compute unit-test returns unit test coverage for DBT sources as well.

The line

dbt-coverage/dbt_coverage/__init__.py

Line 857 in 61cc1ef

catalog_nodes = {**catalog_json["sources"], **catalog_json["nodes"]}

is fetching both sources and nodes, even when the coverage type is unit test.

Are we supposed to check unit-test coverage for DBT sources as well? If not, should we exclude sources if the coverage type is unit-test?

Thank you for creating this amazing project.

[sweco]

Hey @pvij-clear, thanks for pointing this out. I guess it only makes sense to compute this for models. A contribution is welcome or I get to this at some point when I have time.

[pvij-clear]

@sweco Thank you for your swift response. I would be happy to contribute.
Are there any contribution guidelines that we are supposed to follow? Or do I simply create a PR and attach it here?

[sweco]

There is just small snippet of instructions but in general, creating a PR is enough.

https://github.com/slidoapp/dbt-coverage?tab=readme-ov-file#contributing

[pvij]

@sweco Opened #95. Request you to review it. Thanks.