Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README suggest deploying using the classpath #54

Open
mortenschioler opened this issue Mar 3, 2023 · 0 comments
Open

README suggest deploying using the classpath #54

mortenschioler opened this issue Mar 3, 2023 · 0 comments

Comments

@mortenschioler
Copy link

In the README, it is suggested that the correct use of the dependency is

{:deploy {:extra-deps {slipset/deps-deploy {:mvn/version "RELEASE"}}
          :exec-fn deps-deploy.deps-deploy/deploy
          :exec-args {:installer :remote
                      :sign-releases? true
                      :artifact "deps-deploy.jar"}}}

But since the project classpath is not necessary for deploying an artifact that's already been built, I would argue that a better usage with improved performance and less possibility for dependency conflict would be achieved by using :replace-deps (which is the same as :deps in the context of aliases but is more precise):

{:deploy {:replace-deps {slipset/deps-deploy {:mvn/version "RELEASE"}}
          :exec-fn deps-deploy.deps-deploy/deploy
          :exec-args {:installer :remote
                      :sign-releases? true
                      :artifact "deps-deploy.jar"}}}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant