Skip to content

Tests do not create issues if the shim step fails #204

Open
@ianlewis

Description

@ianlewis

Most e2e tests check for needs.shim.outputs.continue == 'yes' but don't check if the shim job actually succeeded. We should create an issue if the shim step fails. This goes for the push or dispatch steps as well.

  • .github/workflows/e2e.container.push.branch1.default.slsa3.yml
  • .github/workflows/e2e.go.tag.main.config-ldflags-noassets.slsa3.yml
  • .github/workflows/e2e.container.tag.main.default.slsa3.yml
  • .github/workflows/e2e.container-based.tag.main.default.slsa3.yml
  • .github/workflows/e2e.go.tag.main.adversarial-asset-provenance.slsa3.yml
  • .github/workflows/e2e.generic.tag.main.assets.slsa3.yml
  • .github/workflows/e2e.go.push.branch1.config-ldflags.slsa3.yml
  • .github/workflows/e2e.go.tag.branch1.config-ldflags-assets.slsa3.yml
  • .github/workflows/e2e.go.release.main.config-ldflags-noassets.slsa3.yml
  • .github/workflows/e2e.go.tag.main.config-ldflags-assets.slsa3.yml
  • .github/workflows/e2e.generic.push.branch1.default.slsa3.yml
  • .github/workflows/e2e.generic.tag.main.annotated.slsa3.yml
  • .github/workflows/e2e.go.release.main.config-ldflags-assets.slsa3.yml
  • .github/workflows/e2e.go.tag.main.adversarial-asset-binary.slsa3.yml
  • .github/workflows/e2e.nodejs.release.main.default.slsa3.yml
  • .github/workflows/e2e.container.tag.main.gcp-workload-identity.slsa3.yml
  • .github/workflows/e2e.container.tag.branch1.default.slsa3.yml
  • .github/workflows/e2e.nodejs.push.branch1.default.slsa3.yml
  • .github/workflows/e2e.go.tag.main.config-ldflags-assets-tag.slsa3.yml
  • .github/workflows/e2e.nodejs.create.main.default.slsa3.yml
  • .github/workflows/e2e.go.tag.main.config-ldflags-assets-prerelease-tag.slsa3.yml
  • .github/workflows/e2e.container.tag.main.registry-username-secret.yml
  • .github/workflows/e2e.generic.release.main.default.slsa3.yml
  • .github/workflows/e2e.generic.tag.branch1.default.slsa3.yml
  • .github/workflows/e2e.generic.tag.main.goreleaser-assets-multi-subjects.slsa3.yml
  • .github/workflows/e2e.go.workflow_dispatch.branch1.config-ldflags.slsa3.yml
  • .github/workflows/e2e.go.tag.main.config-ldflags-assets-draft-tag.slsa3.yml
  • .github/workflows/e2e.go.release.main.config-ldflags-assets-tag.slsa3.yml
  • .github/workflows/e2e.nodejs.tag.main.default.slsa3.yml

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions