Skip to content

Commit 2aed92b

Browse files
authored
Merge pull request #214 from chrisws/master
Android fixes
2 parents 9645a7c + 77b3818 commit 2aed92b

File tree

6 files changed

+16
-14
lines changed

6 files changed

+16
-14
lines changed

src/lib/miniaudio

src/platform/android/app/src/main/assets/main.bas

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -723,9 +723,9 @@ sub main
723723
frm.inputs << bn_files
724724
frm.inputs << bn_online
725725
frm.inputs << bn_scratch
726-
' if (!is_sdl) then
726+
if (!is_sdl) then
727727
frm.inputs << bn_setup
728-
' endif
728+
endif
729729
frm.inputs << bn_about
730730
listFiles frm, path, sortDir, basList
731731
frm = form(frm)

src/platform/android/app/src/main/java/net/sourceforge/smallbasic/MainActivity.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -514,6 +514,7 @@ public String request(String endPoint, String data, String apiKey) throws IOExce
514514
try {
515515
HttpURLConnection conn = getHttpURLConnection(endPoint, (data == null || data.isEmpty()) ? "GET" : "POST", apiKey);
516516
if (data != null && !data.isEmpty()) {
517+
conn.setRequestProperty("Content-Length", "" + data.getBytes().length);
517518
OutputStream os = conn.getOutputStream();
518519
os.write(data.getBytes(StandardCharsets.UTF_8));
519520
os.flush();
@@ -530,10 +531,10 @@ public String request(String endPoint, String data, String apiKey) throws IOExce
530531
in.close();
531532
result = response.toString();
532533
} else {
533-
result = "error:[" + responseCode + "]";
534+
result = "error: [" + responseCode + "]";
534535
}
535536
} catch (Exception e) {
536-
result = "error:[" + e + "]";
537+
result = "error: [" + e + "]";
537538
}
538539
return result;
539540
}
@@ -806,6 +807,7 @@ private HttpURLConnection getHttpURLConnection(String endPoint, String method, S
806807
result.setRequestMethod(method);
807808
result.setInstanceFollowRedirects(true);
808809
if (apiKey != null && !apiKey.isEmpty()) {
810+
result.setRequestProperty("Accept", "application/json");
809811
result.setRequestProperty("Content-Type", "application/json");
810812
result.setRequestProperty("Authorization", "Bearer " + apiKey);
811813
}
@@ -921,7 +923,7 @@ private String readBuffer(File inputFile) {
921923
}
922924
input.close();
923925
} catch (FileNotFoundException e) {
924-
Log.i(TAG, "readBuffer failed: ", e);
926+
Log.i(TAG, "file not found: ", e);
925927
} catch (IOException e) {
926928
Log.i(TAG, "readBuffer failed: ", e);
927929
}

src/platform/android/jni/runtime.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -978,22 +978,22 @@ int Runtime::getFontId() {
978978
int Runtime::invokeRequest(int argc, slib_par_t *params, var_t *retval) {
979979
int result = 0;
980980
if ((argc >= 1 && argc <= 3 && v_is_type(params[0].var_p, V_STR)) &&
981-
(argc < 2 || v_is_type(params[1].var_p, V_STR)) &&
982981
(argc < 3 || v_is_type(params[2].var_p, V_STR))) {
982+
_output->redraw();
983+
983984
JNIEnv *env;
984985
_app->activity->vm->AttachCurrentThread(&env, nullptr);
985-
986986
auto endPoint = env->NewStringUTF(v_getstr(params[0].var_p));
987-
auto data = env->NewStringUTF(argc < 3 ? "" : v_getstr(params[2].var_p));
988-
auto apiKey = env->NewStringUTF(argc < 4 ? "" : v_getstr(params[3].var_p));
987+
auto data = env->NewStringUTF(argc < 2 ? "" : v_getstr(params[1].var_p));
988+
auto apiKey = env->NewStringUTF(argc < 3 ? "" : v_getstr(params[2].var_p));
989989

990990
jclass clazz = env->GetObjectClass(_app->activity->clazz);
991991
const char *signature = "(Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;)Ljava/lang/String;";
992992
jmethodID methodId = env->GetMethodID(clazz, "request", signature);
993993
jstring jstr = (jstring)env->CallObjectMethod(_app->activity->clazz, methodId, endPoint, data, apiKey);
994994
const char *str = env->GetStringUTFChars(jstr, JNI_FALSE);
995995
v_setstr(retval, str);
996-
result = strncmp(str, "error:[", 7) == 0 ? 0 : 1;
996+
result = strncmp(str, "error: [", 8) == 0 ? 0 : 1;
997997
env->ReleaseStringUTFChars(jstr, str);
998998
env->DeleteLocalRef(jstr);
999999
env->DeleteLocalRef(clazz);
@@ -1003,7 +1003,7 @@ int Runtime::invokeRequest(int argc, slib_par_t *params, var_t *retval) {
10031003

10041004
_app->activity->vm->DetachCurrentThread();
10051005
} else {
1006-
v_setstr(retval, "invalid arguments");
1006+
v_setstr(retval, "Invalid request arguments");
10071007
}
10081008
return result;
10091009
}

0 commit comments

Comments
 (0)