Skip to content

Add ca-certificates to Dockerfile.hsm #1823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add ca-certificates to Dockerfile.hsm #1823

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docker/Dockerfile.hsm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ COPY --from=kms /usr/local/bin/step-kms-plugin /usr/local/bin/step-kms-plugin

USER root
RUN apt-get update
RUN apt-get install -y --no-install-recommends pcscd libpcsclite1
RUN apt-get install -y --no-install-recommends pcscd libpcsclite1 ca-certificates
RUN update-ca-certificates
Copy link
Contributor

@tashian tashian May 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
RUN update-ca-certificates

Copy link
Contributor

@tashian tashian May 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The post-install step for ca-certificates will update them, so I don't think update-ca-certificates needs to be explicitly run here.

RUN mkdir -p /run/pcscd
RUN chown step:step /run/pcscd
USER step
Expand Down