Skip to content

Commit 5cd2e26

Browse files
russell-sternrussell-stern
committed
Added vault fast path
1 parent 934b00c commit 5cd2e26

5 files changed

Lines changed: 59 additions & 53 deletions

File tree

‎pkg/settings/cresettings/README.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ flowchart
4242
VaultBase64EncodingEnabled[/VaultBase64EncodingEnabled\]:::gate
4343
VaultForceEmptyOCRRounds[/VaultForceEmptyOCRRounds\]:::gate
4444
VaultOptimizationsEnabled[/VaultOptimizationsEnabled\]:::gate
45+
VaultFastPathGetSecretsEnabled[/VaultFastPathGetSecretsEnabled\]:::gate
4546
VaultOwnerAddressCanonicalizationEnabled[/VaultOwnerAddressCanonicalizationEnabled\]:::gate
4647
VaultSignedResponseRequestIDEnabled[/VaultSignedResponseRequestIDEnabled\]:::gate
4748
end

‎pkg/settings/cresettings/defaults.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
"VaultBase64EncodingEnabled": "false",
1010
"VaultForceEmptyOCRRounds": "false",
1111
"VaultOptimizationsEnabled": "false",
12+
"VaultFastPathGetSecretsEnabled": "false",
1213
"VaultOwnerAddressCanonicalizationEnabled": "false",
1314
"VaultSignedResponseRequestIDEnabled": "false",
1415
"GatewayHTTPGlobalRate": "500rps:500",

‎pkg/settings/cresettings/defaults.toml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ PropagateOrgIDInRequestMetadata = 'false'
88
VaultBase64EncodingEnabled = 'false'
99
VaultForceEmptyOCRRounds = 'false'
1010
VaultOptimizationsEnabled = 'false'
11+
VaultFastPathGetSecretsEnabled = 'false'
1112
VaultOwnerAddressCanonicalizationEnabled = 'false'
1213
VaultSignedResponseRequestIDEnabled = 'false'
1314
GatewayHTTPGlobalRate = '500rps:500'

‎pkg/settings/cresettings/settings.go‎

Lines changed: 55 additions & 53 deletions
Original file line numberDiff line numberDiff line change
@@ -58,24 +58,25 @@ var Default = Schema{
5858
GatewayVaultManagementEnabled: Bool(true),
5959
VaultJWTAuthEnabled: Bool(false),
6060
// Deprecated: retained for backwards compatibility; workflow owner identifies secret ownership.
61-
VaultOrgIdAsSecretOwnerEnabled: Bool(false),
62-
PropagateOrgIDInRequestMetadata: Bool(false),
63-
VaultBase64EncodingEnabled: Bool(false),
64-
VaultForceEmptyOCRRounds: Bool(false),
65-
VaultOptimizationsEnabled: Bool(false),
66-
VaultOwnerAddressCanonicalizationEnabled: Bool(false),
67-
VaultSignedResponseRequestIDEnabled: Bool(false),
68-
GatewayHTTPGlobalRate: Rate(rate.Limit(500), 500),
69-
GatewayHTTPPerNodeRate: Rate(rate.Limit(100), 100),
70-
GatewayConfidentialRelayGlobalRate: Rate(rate.Limit(50), 10),
71-
GatewayConfidentialRelayPerNodeRate: Rate(rate.Limit(10), 10),
72-
GatewayHTTPActionMtlsRequestRate: Rate(rate.Every(30*time.Second), 0),
73-
GatewayHTTPActionMtlsConcurrencyLimit: Int(50),
74-
TriggerRegistrationStatusUpdateTimeout: Duration(0 * time.Second),
75-
BaseTriggerRetryInterval: Duration(30 * time.Second),
76-
BaseTriggerMaxRetries: Int(20),
77-
BaseTriggerPruneAge: Duration(24 * time.Hour),
78-
BaseTriggerMaxSendsPerTick: Int(20),
61+
VaultOrgIdAsSecretOwnerEnabled: Bool(false),
62+
PropagateOrgIDInRequestMetadata: Bool(false),
63+
VaultBase64EncodingEnabled: Bool(false),
64+
VaultForceEmptyOCRRounds: Bool(false),
65+
VaultOptimizationsEnabled: Bool(false),
66+
VaultFastPathGetSecretsEnabled: Bool(false),
67+
VaultOwnerAddressCanonicalizationEnabled: Bool(false),
68+
VaultSignedResponseRequestIDEnabled: Bool(false),
69+
GatewayHTTPGlobalRate: Rate(rate.Limit(500), 500),
70+
GatewayHTTPPerNodeRate: Rate(rate.Limit(100), 100),
71+
GatewayConfidentialRelayGlobalRate: Rate(rate.Limit(50), 10),
72+
GatewayConfidentialRelayPerNodeRate: Rate(rate.Limit(10), 10),
73+
GatewayHTTPActionMtlsRequestRate: Rate(rate.Every(30*time.Second), 0),
74+
GatewayHTTPActionMtlsConcurrencyLimit: Int(50),
75+
TriggerRegistrationStatusUpdateTimeout: Duration(0 * time.Second),
76+
BaseTriggerRetryInterval: Duration(30 * time.Second),
77+
BaseTriggerMaxRetries: Int(20),
78+
BaseTriggerPruneAge: Duration(24 * time.Hour),
79+
BaseTriggerMaxSendsPerTick: Int(20),
7980

8081
// DANGER(cedric): Be extremely careful changing these vault limits below as they act as a default value
8182
// used by the Vault OCR plugin -- changing these values could cause issues with the plugin during an image
@@ -230,12 +231,12 @@ var Default = Schema{
230231
CallLimit: Int(20),
231232
},
232233
HTTPAction: httpAction{
233-
CallLimit: Int(5),
234-
CacheAgeLimit: Duration(10 * time.Minute),
235-
ConnectionTimeout: Duration(10 * time.Second),
236-
RequestSizeLimit: Size(10 * config.KByte),
237-
ResponseSizeLimit: Size(100 * config.KByte),
238-
GatewayProxyDonID: String(""),
234+
CallLimit: Int(5),
235+
CacheAgeLimit: Duration(10 * time.Minute),
236+
ConnectionTimeout: Duration(10 * time.Second),
237+
RequestSizeLimit: Size(10 * config.KByte),
238+
ResponseSizeLimit: Size(100 * config.KByte),
239+
GatewayProxyDonID: String(""),
239240
},
240241
ConfidentialHTTP: confidentialHTTP{
241242
CallLimit: Int(5),
@@ -264,25 +265,26 @@ var Default = Schema{
264265
}
265266

266267
type Schema struct {
267-
WorkflowLimit Setting[int] `unit:"{workflow}"`
268-
WorkflowExecutionConcurrencyLimit Setting[int] `unit:"{workflow}"`
269-
GatewayIncomingPayloadSizeLimit Setting[config.Size]
270-
GatewayVaultManagementEnabled Setting[bool]
271-
VaultJWTAuthEnabled Setting[bool]
272-
VaultOrgIdAsSecretOwnerEnabled Setting[bool] // Deprecated
273-
PropagateOrgIDInRequestMetadata Setting[bool]
274-
VaultBase64EncodingEnabled Setting[bool]
275-
VaultForceEmptyOCRRounds Setting[bool]
276-
VaultOptimizationsEnabled Setting[bool]
277-
VaultOwnerAddressCanonicalizationEnabled Setting[bool]
278-
VaultSignedResponseRequestIDEnabled Setting[bool]
279-
GatewayHTTPGlobalRate Setting[config.Rate]
280-
GatewayHTTPPerNodeRate Setting[config.Rate]
281-
GatewayConfidentialRelayGlobalRate Setting[config.Rate]
282-
GatewayConfidentialRelayPerNodeRate Setting[config.Rate]
283-
GatewayHTTPActionMtlsRequestRate Setting[config.Rate]
284-
GatewayHTTPActionMtlsConcurrencyLimit Setting[int] `unit:"{request}"`
285-
TriggerRegistrationStatusUpdateTimeout Setting[time.Duration]
268+
WorkflowLimit Setting[int] `unit:"{workflow}"`
269+
WorkflowExecutionConcurrencyLimit Setting[int] `unit:"{workflow}"`
270+
GatewayIncomingPayloadSizeLimit Setting[config.Size]
271+
GatewayVaultManagementEnabled Setting[bool]
272+
VaultJWTAuthEnabled Setting[bool]
273+
VaultOrgIdAsSecretOwnerEnabled Setting[bool] // Deprecated
274+
PropagateOrgIDInRequestMetadata Setting[bool]
275+
VaultBase64EncodingEnabled Setting[bool]
276+
VaultForceEmptyOCRRounds Setting[bool]
277+
VaultOptimizationsEnabled Setting[bool]
278+
VaultFastPathGetSecretsEnabled Setting[bool]
279+
VaultOwnerAddressCanonicalizationEnabled Setting[bool]
280+
VaultSignedResponseRequestIDEnabled Setting[bool]
281+
GatewayHTTPGlobalRate Setting[config.Rate]
282+
GatewayHTTPPerNodeRate Setting[config.Rate]
283+
GatewayConfidentialRelayGlobalRate Setting[config.Rate]
284+
GatewayConfidentialRelayPerNodeRate Setting[config.Rate]
285+
GatewayHTTPActionMtlsRequestRate Setting[config.Rate]
286+
GatewayHTTPActionMtlsConcurrencyLimit Setting[int] `unit:"{request}"`
287+
TriggerRegistrationStatusUpdateTimeout Setting[time.Duration]
286288

287289
BaseTriggerRetryInterval Setting[time.Duration]
288290
BaseTriggerMaxRetries Setting[int] `unit:"{attempt}"`
@@ -373,10 +375,10 @@ type Workflows struct {
373375
ConfidentialHTTP confidentialHTTP
374376
Secrets secrets
375377

376-
FeatureMultiTriggerExecutionIDsActiveAt Setting[config.Timestamp] // Deprecated
377-
FeatureMultiTriggerExecutionIDsActivePeriod Setting[Range[config.Timestamp]]
378-
FeatureChainCapabilityHashBasedOCRActivePeriod Setting[Range[config.Timestamp]]
379-
FeatureEVMWriteReportL1FeeActivePeriod Setting[Range[config.Timestamp]]
378+
FeatureMultiTriggerExecutionIDsActiveAt Setting[config.Timestamp] // Deprecated
379+
FeatureMultiTriggerExecutionIDsActivePeriod Setting[Range[config.Timestamp]]
380+
FeatureChainCapabilityHashBasedOCRActivePeriod Setting[Range[config.Timestamp]]
381+
FeatureEVMWriteReportL1FeeActivePeriod Setting[Range[config.Timestamp]]
380382
FeatureAptosWriteReportBlockTimestampActivePeriod Setting[Range[config.Timestamp]]
381383
}
382384

@@ -419,12 +421,12 @@ type chainRead struct {
419421
PayloadSizeLimit Setting[config.Size]
420422
}
421423
type httpAction struct {
422-
CallLimit Setting[int] `unit:"{call}"`
423-
CacheAgeLimit Setting[time.Duration]
424-
ConnectionTimeout Setting[time.Duration]
425-
RequestSizeLimit Setting[config.Size]
426-
ResponseSizeLimit Setting[config.Size]
427-
GatewayProxyDonID Setting[string]
424+
CallLimit Setting[int] `unit:"{call}"`
425+
CacheAgeLimit Setting[time.Duration]
426+
ConnectionTimeout Setting[time.Duration]
427+
RequestSizeLimit Setting[config.Size]
428+
ResponseSizeLimit Setting[config.Size]
429+
GatewayProxyDonID Setting[string]
428430
}
429431
type perOrgHTTPAction struct {
430432
MtlsRateLimit Setting[config.Rate]

‎pkg/settings/cresettings/settings_test.go‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,7 @@ func TestSchema_Unmarshal(t *testing.T) {
131131
assert.False(t, cfg.VaultBase64EncodingEnabled.DefaultValue)
132132
assert.False(t, cfg.VaultForceEmptyOCRRounds.DefaultValue)
133133
assert.False(t, cfg.VaultOptimizationsEnabled.DefaultValue)
134+
assert.False(t, cfg.VaultFastPathGetSecretsEnabled.DefaultValue)
134135
assert.False(t, cfg.VaultOwnerAddressCanonicalizationEnabled.DefaultValue)
135136
assert.False(t, cfg.VaultSignedResponseRequestIDEnabled.DefaultValue)
136137
assert.Equal(t, config.Rate{Limit: rate.Limit(20), Burst: 7}, cfg.GatewayConfidentialRelayGlobalRate.DefaultValue)

0 commit comments

Comments
 (0)