Lesson 11: error: 'createCollectible Sequence has incorrect length, expected 1 but got 0'

[brownandrew1390]

Received the following error when trying to run advanced_collectible/deploy_and_create.py:

  File "C:\Users\Andrew\.local\pipx\venvs\eth-brownie\lib\site-packages\brownie\_cli\run.py", line 50, in main
    return_value, frame = run(
  File "C:\Users\Andrew\.local\pipx\venvs\eth-brownie\lib\site-packages\brownie\project\scripts.py", line 103, in run
    return_value = f_locals[method_name](*args, **kwargs)
  File "\Users\Andrew\Desktop\Coding\smart_contract_dev_tutorial\nft\scripts\advanced_collectible\deploy_and_create.py", line 21, in main
    deploy_and_create()
  File "\Users\Andrew\Desktop\Coding\smart_contract_dev_tutorial\nft\scripts\advanced_collectible\deploy_and_create.py", line 14, in deploy_and_create
    creating_tx = advanced_collectible.createCollectible({"from": account})
  File "C:\Users\Andrew\.local\pipx\venvs\eth-brownie\lib\site-packages\brownie\network\contract.py", line 1622, in __call__
    return self.transact(*args)
  File "C:\Users\Andrew\.local\pipx\venvs\eth-brownie\lib\site-packages\brownie\network\contract.py", line 1505, in transact
    data=self.encode_input(*args),
  File "C:\Users\Andrew\.local\pipx\venvs\eth-brownie\lib\site-packages\brownie\network\contract.py", line 1540, in encode_input
    data = format_input(self.abi, args)
  File "C:\Users\Andrew\.local\pipx\venvs\eth-brownie\lib\site-packages\brownie\convert\normalize.py", line 20, in format_input
    raise type(e)(f"{abi['name']} {e}") from None
ValueError: createCollectible Sequence has incorrect length, expected 1 but got 0

Here is the corresponding scripts for:
advanced_collectible/deploy_and_create.py

from scripts.helpful_scripts import get_account, OPENSEA_URL, get_contract, fund_with_link
from brownie import AdvancedCollectible, network, config

def deploy_and_create():
    account = get_account()
    advanced_collectible = AdvancedCollectible.deploy(
        get_contract("vrf_coordinator"),
        get_contract("link_token"),
        config["networks"][network.show_active()]["keyhash"],
        config["networks"][network.show_active()]["fee"],       
        {"from": account},
    )
    fund_with_link(advanced_collectible.address)
    creating_tx = advanced_collectible.createCollectible({"from": account})
    creating_tx.wait(1)
    print("New token has been created!")



def main():
    deploy_and_create()

helpful_scripts.py

from brownie import accounts, network, config, LinkToken, VRFCoordinatorMock, Contract
from web3 import Web3

LOCAL_BLOCKCHAIN_ENVIRONMENTS = ["hardhat", "development", "ganache", "mainnet-fork"]
OPENSEA_URL = "https://testnets.opensea.io/assets/{}/{}"


def get_account(index=None, id=None):
    if index:
        return accounts[index]
    if network.show_active() in LOCAL_BLOCKCHAIN_ENVIRONMENTS:
        return accounts[0]
    if id:
        return accounts.load(id)
    return accounts.add(config["wallets"]["from_key"])


contract_to_mock = {"link_token": LinkToken, "vrf_coordinator": VRFCoordinatorMock}


def get_contract(contract_name):
    """
    This function will either:
        - Get an address from the config
        - Or deploy a Mock to use for a network that doesn't have the conract
    Args:
        contract_name (string): This is the name of the contract that we will get
        from the config or deploy
    Returns:
        brownie.network.contract.ProjectContract: This is the most recently deployed
        Contract of the type specified by a dictionary. This could either be a mock
        or a 'real' contract on a live network.
    """
    # link_token
    # LinkToken
    contract_type = contract_to_mock[contract_name]
    if network.show_active() in LOCAL_BLOCKCHAIN_ENVIRONMENTS:
        if len(contract_type) <= 0:
            deploy_mocks()
        contract = contract_type[-1]
    else:
        contract_address = config["networks"][network.show_active()][contract_name]
        contract = Contract.from_abi(
            contract_type._name, contract_address, contract_type.abi
        )
    return contract


def deploy_mocks():
    """
    Use this script if you want to deploy mocks to a testnet
    """
    print(f"The active network is {network.show_active()}")
    print("Deploying mocks...")
    account = get_account()
    print("Deploying Mock LinkToken...")
    link_token = LinkToken.deploy({"from": account})
    print(f"Link Token deployed to {link_token.address}")
    print("Deploying Mock VRF Coordinator...")
    vrf_coordinator = VRFCoordinatorMock.deploy(link_token.address, {"from": account})
    print(f"VRFCoordinator deployed to {vrf_coordinator.address}")
    print("All done!")

def fund_with_link(contract_address, account=None, link_token=None, amount=Web3.toWei(1, "ether")):
    account = account if account else get_account()
    link_token = link_token if link_token else get_contract("link_token")
    tx = link_token.transfer(contract_address, amount, {"from": account})
    # link_token_contract = interface.LinkTokenInterface(link_token.address)
    # tx = link_token_contract.transfer(contract_address, amount, {"from": account})
    tx.wait(1)
    print("Funded contract!")
    return tx

[cromewar]

Hello @brownandrew1390 I reviewed your code and seems everything is pretty much ok, your error is pointing to the ABI data = format_input(self.abi, args), do you have this contract on your build folder?

if yes, maybe brownie is reading incorrectly the ABI from the contract, so always is a good idea to delete the build folder and compile again.

Also, could you please share the AdvancedCollectibl contract code here please?

[brownandrew1390]

// NFT Contract
// Where the tokenURI can be one of 3 different dogs
// Randomly selected

// SPDX License-Identifier: MIT
pragma solidity 0.6.6;

import "@openzeppelin/contracts/token/ERC721/ERC721.sol";
import "@chainlink/contracts/src/v0.6/VRFConsumerBase.sol";

contract AdvancedCollectible is ERC721, VRFConsumerBase {
    uint256 public tokenCounter;
    bytes32 public keyhash;
    uint256 public fee;
    enum Breed{PUG, SHIBA_INU, ST_BERNARD}
    mapping(uint256 => Breed) public tokenIdToBreed;
    mapping(bytes32 => address) public requestIdToSender;
    event requestedCollectible(bytes32 indexed requestId, address requester);
    event breedAssigned(uint256 indexed tokenId, Breed breed);

    constructor(
        address _VRFCoordinator, 
        address _linkToken, 
        bytes32 _keyhash, 
        uint256 _fee) public 
        VRFConsumerBase(_VRFCoordinator, _linkToken)
        ERC721("Dogie", "DOG")
        {
            tokenCounter = 0;
            keyhash = _keyhash;
            fee = _fee;
        }

    function createCollectible(string memory tokenURI) public returns(bytes32){
        bytes32 requestId = requestRandomness(keyhash, fee);
        requestIdToSender[requestId] = msg.sender;
        emit requestedCollectible(requestId, msg.sender);
    }
    function fulfillRandomness(bytes32 requestId, uint256 randomNumber) internal override {
        Breed breed = Breed(randomNumber % 3);
        uint256 newTokenId = tokenCounter;
        tokenIdToBreed[newTokenId] = breed;
        emit breedAssigned(newTokenId, breed);
        address owner = requestIdToSender[requestId];
        _safeMint(owner, newTokenId);
        tokenCounter = tokenCounter + 1;
    }

    function setTokenURI(uint256 tokenId, string memory _tokenURI) public {
        // pug, shiba inu, st bernard
        require(_isApprovedOrOwner(
            _msgSender(), tokenId), "ERC721: caller is not owner nor approved");
        _setTokenURI(tokenId, _tokenURI);

    }
}

[cromewar]

Ok I found the problem your createCollectible goes like this:

it requires a string called TokenURI

  function createCollectible(string memory tokenURI) public returns(bytes32){
        bytes32 requestId = requestRandomness(keyhash, fee);
        requestIdToSender[requestId] = msg.sender;
        emit requestedCollectible(requestId, msg.sender);
    }

and on your deploy script:

 creating_tx = advanced_collectible.createCollectible({"from": account})

You are not sending the expected tokenURI and that's the reason why is failing.

The function should look like this:

function createCollectible() public {
        bytes32 requestId = requestRandomness(keyhash, fee);
        requestIdToSender[requestId] = msg.sender;
        emit requestedCollectible(requestId, msg.sender);
    }

[brownandrew1390]

Appreciate it! Did the trick.

[WeTheArtist]

Thank you , this helped me as well!