Merge pull request #285 from smartdevicelink/release/1.1.0

Release/1.1.0

Author: crokita

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,4 +1,4 @@
-[Things to note: Pull Requests **must** fix an issue. Discussion about the feature / bug takes place in the issue, discussion of the implementation takes place in the PR. Please also see the [Contributing Guide](./CONTRIBUTING.md) for information on branch naming and the CLA, and the [SmartDeviceLink GitHub Best Practices](https://d83tozu1c8tt6.cloudfront.net/media/resources/SDL_GitHub_BestPractices.pdf) document for more information on how to enter a pull request.  Once this PR is ready for review, please request one from @nickschwab.
+[Things to note: Pull Requests **must** fix an issue. Discussion about the feature / bug takes place in the issue, discussion of the implementation takes place in the PR. Please also see the [Contributing Guide](./CONTRIBUTING.md) for information on branch naming and the CLA, and the [SmartDeviceLink GitHub Best Practices](https://d83tozu1c8tt6.cloudfront.net/media/resources/SDL_GitHub_BestPractices.pdf) document for more information on how to enter a pull request.  Once this PR is ready for review, please request one from @crokita.
 
 Delete the above section when you've read it.]
 

examples/js/hello-sdl/SDL.min.js

@@ -56,7 +56,10 @@
                         SDL.rpc.enums.AppHMIType.DEFAULT,
                     ])
                     .setTransportConfig(new SDL.transport.WebSocketClientConfig('ws://localhost', 5050))
-                    .setAppIcon(file);
+                    .setAppIcon(file)
+                    .setRpcNotificationListeners({
+                        [SDL.rpc.enums.FunctionID.OnHMIStatus]: this._onHmiStatusListener.bind(this),
+                    });
 
                 this._appConfig = new SDL.manager.AppConfig()
                     .setLifecycleConfig(this._lifecycleConfig);
@@ -94,9 +97,7 @@
                     });
 
                 this._sdlManager = new SDL.manager.SdlManager(this._appConfig, managerListener);
-                this._sdlManager
-                    .start()
-                    .addRpcListener(SDL.rpc.enums.FunctionID.OnHMIStatus, this._onHmiStatusListener.bind(this));
+                this._sdlManager.start();
             }
 
             async _onConnected () {
@@ -168,13 +169,13 @@
                             .setMainField2('')
                             .setMainField3('');
 
-                        this._sdlManager.sendRpc(showCountdown); // don't wait for a response
+                        this._sdlManager.sendRpcResolve(showCountdown); // don't wait for a response
 
                         await this._sleep();
                     }
 
                     // tear down the app
-                    await this._sdlManager.sendRpc(new SDL.rpc.messages.UnregisterAppInterface());
+                    await this._sdlManager.sendRpcResolve(new SDL.rpc.messages.UnregisterAppInterface());
 
                     this._sdlManager.dispose();
                 }