Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revisit exception safety #93

Open
emaxerrno opened this issue Mar 16, 2017 · 2 comments
Open

revisit exception safety #93

emaxerrno opened this issue Mar 16, 2017 · 2 comments
Assignees
@emaxerrno
Labels
enhancement help wanted
Milestone
1.0

Comments

@emaxerrno
Copy link
Collaborator

We are breaking some laws regarding exception safety.

see all the noexcept methods for instances.
@emaxerrno emaxerrno modified the milestone: 1.0 Jun 8, 2017
@emaxerrno emaxerrno self-assigned this Jun 8, 2017
@emaxerrno
Copy link
Collaborator Author

basically 2 things.

To prevent allocations either use a union {} or a pointer std::unique_ptr or seastar::lw_shared_ptr

that's it.

@emaxerrno emaxerrno reopened this Jun 13, 2017
@emaxerrno
Copy link
Collaborator Author

clang-tidy warns for this too. so all the superficial bugs were fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emaxerrno emaxerrno

Labels
enhancement help wanted
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@emaxerrno