Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put namespace in completion label description #194

Closed
milesziemer opened this issue Feb 13, 2025 · 0 comments · Fixed by #195
Closed

Put namespace in completion label description #194

milesziemer opened this issue Feb 13, 2025 · 0 comments · Fixed by #195
Assignees

Comments

@milesziemer
Copy link
Contributor

From lsp docs:

export interface CompletionItemLabelDetails {

	/**
	 * An optional string which is rendered less prominently directly after
	 * {@link CompletionItem.label label}, without any spacing. Should be
	 * used for function signatures or type annotations.
	 */
	detail?: string;

	/**
	 * An optional string which is rendered less prominently after
	 * {@link CompletionItemLabelDetails.detail}. Should be used for fully qualified
	 * names or file path.
	 */
	description?: string;
}

We are using detail for the shape namespace, but we should be using description. And we should probably make it the fully-qualified shape id.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant