Skip to content

Commit 51a4537

Browse files
authored
Fix "too many open files" error when running integration tests (apache#800)
This was due to the fact that each token fetch created a new client, and the client wasn't closed.
1 parent 9b1f34f commit 51a4537

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

integration-tests/src/main/java/org/apache/polaris/service/it/env/PolarisClient.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ public String obtainToken(PrincipalWithCredentials principal) {
115115

116116
/** Requests an access token from the Polaris server for the given {@link ClientCredentials}. */
117117
public String obtainToken(ClientCredentials credentials) {
118-
return polarisServerManager().accessManager().obtainAccessToken(endpoints, credentials);
118+
return polarisServerManager().accessManager(client).obtainAccessToken(endpoints, credentials);
119119
}
120120

121121
private boolean ownedName(String name) {

integration-tests/src/main/java/org/apache/polaris/service/it/ext/PolarisServerManager.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,8 @@ public interface PolarisServerManager {
5151
*/
5252
Server serverForContext(ExtensionContext context);
5353

54-
default PolarisAccessManager accessManager() {
55-
return new IcebergTokenAccessManager(createClient());
54+
default PolarisAccessManager accessManager(Client client) {
55+
return new IcebergTokenAccessManager(client);
5656
}
5757

5858
/** Create a new HTTP client for accessing the server targeted by tests. */

0 commit comments

Comments
 (0)