Skip to content

Commit 17af25b

Browse files
SNOW-1899737: Make test_crud more rubust for default string length (#816)
1 parent d6cf756 commit 17af25b

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

tests/test_crud.c

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
#include "utils/test_setup.h"
66

77
void _fetch_data(SF_STMT *sfstmt, int64 expected_sum) {
8-
char *cenv = getenv("CLOUD_PROVIDER");
98
SF_STATUS status = snowflake_query(sfstmt, "select * from t", 0);
109
if (status != SF_STATUS_SUCCESS) {
1110
dump_error(&(sfstmt->error));
@@ -17,6 +16,7 @@ void _fetch_data(SF_STMT *sfstmt, int64 expected_sum) {
1716
assert_int_equal(num_fields, 2);
1817

1918
SF_COLUMN_DESC *descs = snowflake_desc(sfstmt);
19+
uint64 min_default_varchar_size = 16 * 1024 * 1024;
2020
uint64* max_varchar_size_p = NULL;
2121
snowflake_get_attribute(sfstmt->connection, SF_CON_MAX_VARCHAR_SIZE, (void**)&max_varchar_size_p);
2222
int i;
@@ -38,11 +38,8 @@ void _fetch_data(SF_STMT *sfstmt, int64 expected_sum) {
3838
assert_int_equal(descs[i].idx, 2);
3939
assert_int_equal(descs[i].type, SF_DB_TYPE_TEXT);
4040
assert_int_equal(descs[i].c_type, SF_C_TYPE_STRING);
41-
// TODO: SNOW-1899737 temporarily disable length check on AZURE/GCP
42-
if (cenv && !strncmp(cenv, "AWS", 4)) {
43-
assert_int_equal(descs[i].byte_size, *max_varchar_size_p);
44-
assert_int_equal(descs[i].internal_size, *max_varchar_size_p);
45-
}
41+
assert_in_range(descs[i].byte_size, min_default_varchar_size, *max_varchar_size_p);
42+
assert_in_range(descs[i].internal_size, min_default_varchar_size, *max_varchar_size_p);
4643
assert_int_equal(descs[i].precision, 0);
4744
assert_int_equal(descs[i].scale, 0);
4845
assert_int_equal(descs[i].null_ok, 1);

0 commit comments

Comments
 (0)