Skip to content

Fix nav bar CollapseButton behavior #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

phil-snowplow
Copy link
Contributor

Fixes https://snplow.atlassian.net/browse/DOC-122.

  • Problem: The expand/collapse arrow was both expanding the sidebar
    section AND navigating to the category page
  • Root cause: The CollapseButton component was
    programmatically clicking the link element after expanding
  • Solution: Simplified the handleClick function to only toggle the
    collapse state (updateCollapsed(!collapsed)) without any navigation logic

Copy link

netlify bot commented Jul 11, 2025

Deploy Preview for snowplow-docs ready!

Name Link
🔨 Latest commit 8c8c243
🔍 Latest deploy log https://app.netlify.com/projects/snowplow-docs/deploys/6875589e774129000819a18e
😎 Deploy Preview https://deploy-preview-1320--snowplow-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@phil-snowplow phil-snowplow requested a review from mscwilson July 11, 2025 16:13
@mscwilson mscwilson changed the title fix CollapseButton behavior Fix CollapseButton behavior Jul 14, 2025
@mscwilson mscwilson changed the title Fix CollapseButton behavior Fix nav bar CollapseButton behavior Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants