Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Define enum for block types. #149

Open
1 task done
itsWindows11 opened this issue Oct 17, 2024 · 0 comments
Open
1 task done

Code Quality: Define enum for block types. #149

itsWindows11 opened this issue Oct 17, 2024 · 0 comments

Comments

@itsWindows11
Copy link
Contributor

⚠️ Search for existing issues first ⚠️

  • I have searched the existing issues, and there is no existing issue for my problem

Which Operating System are you using?

Windows

Which version of data-river are you using?

0.0.1

Describe your issue.

Currently, block types are worked with as plain strings as seen here:

https://github.com/softflow24/data-river/blob/development/packages%2Feditor%2Fsrc%2Fservices%2FReactFlowMapperService.ts#L22-L34

To make things easier, we can add an enum type we can use for comparison.

Paste Error from Terminal/Console

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant