From b6ac4458ede550dd0085dd971bc0536d1e60957c Mon Sep 17 00:00:00 2001 From: Pau Ramon Revilla Date: Tue, 25 Mar 2025 15:46:53 +0100 Subject: [PATCH 1/2] Typo makes `getPositionToScreen` buggy AFAIK, we want to use scrollY not screenY. --- packages/mouse/src/common.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/mouse/src/common.ts b/packages/mouse/src/common.ts index 174723e5f..3a54889b0 100644 --- a/packages/mouse/src/common.ts +++ b/packages/mouse/src/common.ts @@ -164,5 +164,5 @@ export const getPositionToScreen = isServer ? (): Position => DEFAULT_MOUSE_POSITION : (pageX: number, pageY: number): Position => ({ x: pageX - window.scrollX, - y: pageY - window.screenY, + y: pageY - window.scrollY, }); From 8fe4e2ad93a610cd1871a882cd126cbed8757700 Mon Sep 17 00:00:00 2001 From: Damian Tarnawski Date: Wed, 23 Apr 2025 09:26:09 +0200 Subject: [PATCH 2/2] Create nasty-otters-camp.md --- .changeset/nasty-otters-camp.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/nasty-otters-camp.md diff --git a/.changeset/nasty-otters-camp.md b/.changeset/nasty-otters-camp.md new file mode 100644 index 000000000..f514feb30 --- /dev/null +++ b/.changeset/nasty-otters-camp.md @@ -0,0 +1,5 @@ +--- +"@solid-primitives/mouse": patch +--- + +Use `scrollY` not `screenY` in `getPositionToScreen`