Specs: make click_icon resilient to intercepted clicks (scroll + JS click) and update admin docs to use Spree.admin_user_class

Author: elia

admin/docs/index_pages.md

@@ -16,15 +16,15 @@ class SolidusAdmin::UsersController < SolidusAdmin::BaseController
   include SolidusAdmin::ControllerHelpers::Search
 
   def index
-    users = apply_search_to(Spree.user_class.order(id: :desc), param: :q)
+    users = apply_search_to(Spree.admin_user_class.order(id: :desc), param: :q)
     # ...
 ```
 
 For pagination support, the index action should also call the `set_page_and_extract_portion_from` method provided by the `geared_pagination` gem. This method sets the `@page` instance variable to the paginated collection and returns the portion of the collection to be displayed on the current page.
 
 ```ruby
 def index
-  users = apply_search_to(Spree.user_class.order(id: :desc), param: :q)
+  users = apply_search_to(Spree.admin_user_class.order(id: :desc), param: :q)
   set_page_and_extract_portion_from(users)
   # ...
 ```
@@ -33,7 +33,7 @@ Finally, the index action should render the `index` component passing the `@page
 
 ```ruby
 def index
-  users = apply_search_to(Spree.user_class.order(id: :desc), param: :q)
+  users = apply_search_to(Spree.admin_user_class.order(id: :desc), param: :q)
   set_page_and_extract_portion_from(users)
   render component('users/index').new(page: @page)
 end
@@ -50,7 +50,7 @@ The index component requires only the `page` argument during initialization, all
 ```ruby
 class SolidusAdmin::Users::Index < Solidus::Admin::UI::Pages::Index
   def model_class
-    Spree.user_class
+    Spree.admin_user_class
   end
 end
 
@@ -92,7 +92,7 @@ end
 ```ruby
 # in the controller
 def delete
-  @users = Spree.user_class.where(id: params[:id])
+  @users = Spree.admin_user_class.where(id: params[:id])
   @users.destroy_all
   flash[:notice] = "Admin users deleted"
   redirect_to solidus_admin.users_path, status: :see_other
@@ -124,7 +124,7 @@ module SolidusAdmin
     search_scope(:all)
 
     def index
-      users = apply_search_to(Spree.user_class.order(id: :desc), param: :q)
+      users = apply_search_to(Spree.admin_user_class.order(id: :desc), param: :q)
       # ...
 ```
 

core/lib/spree/testing_support/capybara_ext.rb

@@ -4,7 +4,13 @@ module Spree
   module TestingSupport
     module CapybaraExt
       def click_icon(type)
-        find(".fa-#{type}").click
+        el = find(".fa-#{type}", visible: :all)
+        el.click
+      rescue Selenium::WebDriver::Error::ElementClickInterceptedError
+        # When a floating element (eg. tooltips/overlays) intercepts the click,
+        # scroll the target into view and dispatch a click via JS to keep tests stable.
+        page.execute_script('arguments[0].scrollIntoView({block: "center"});', el.native)
+        page.execute_script('arguments[0].click();', el.native)
       end
 
       def eventually_fill_in(field, options = {})