Manually fix linting errors

Using standardrb --fix-unsafely and manualy correct
where the fix was not working.

Author: tvdeyen

Gemfile

@@ -81,4 +81,4 @@ group :release do
 end
 
 custom_gemfile = File.expand_path("Gemfile-custom", __dir__)
-eval File.read(custom_gemfile), nil, custom_gemfile, 0 if File.exist?(custom_gemfile)
+eval File.read(custom_gemfile), nil, custom_gemfile, 0 if File.exist?(custom_gemfile) # rubocop:disable Security/Eval

admin/app/components/solidus_admin/ui/forms/field/component.rb

@@ -27,7 +27,7 @@ def self.text_field(form, method, object: nil, hint: nil, tip: nil, size: :m, **
         tag: :input,
         size:,
         value: object.public_send(method),
-        error: (errors.to_sentence.capitalize if errors),
+        error: errors&.to_sentence&.capitalize,
         **attributes
       }
     )
@@ -44,7 +44,7 @@ def self.select(form, method, choices, object: nil, hint: nil, tip: nil, size: :
       name: "#{object_name}[#{method}]#{"[]" if attributes[:multiple].present?}",
       choices:,
       value: object.try(method),
-      error: (errors.to_sentence.capitalize if errors),
+      error: errors&.to_sentence&.capitalize,
       **attributes
     )
   end
@@ -62,7 +62,7 @@ def self.text_area(form, method, object: nil, hint: nil, tip: nil, size: :m, **a
         size:,
         tag: :textarea,
         value: object.public_send(method),
-        error: (errors.to_sentence.capitalize if errors),
+        error: errors&.to_sentence&.capitalize,
         **attributes
       }
     )

admin/app/components/solidus_admin/ui/table/component.rb

@@ -19,11 +19,11 @@ def initialize(**args)
     end
 
     def singular_name
-      self[:class].model_name.human if self[:class]
+      self[:class]&.model_name&.human
     end
 
     def plural_name
-      self[:class].model_name.human.pluralize if self[:class]
+      self[:class]&.model_name&.human&.pluralize
     end
   end
 

admin/app/components/solidus_admin/ui/table/ransack_filter/component.rb

@@ -53,7 +53,7 @@ def build(type, value, opt_index = nil)
   # @return [Boolean] Returns true if the checkbox should be checked, false otherwise.
   def checked?(value)
     conditions = params.dig(:q, :g, @index.to_s, :c)
-    conditions && conditions.values.any? { |c| c[:v]&.include?(value.to_s) }
+    conditions&.values&.any? { |c| c[:v]&.include?(value.to_s) }
   end
 
   SUFFIXES = {

admin/app/controllers/solidus_admin/orders_controller.rb

@@ -46,7 +46,7 @@ def update
       load_order
 
       @order.assign_attributes(order_params)
-      @order.email ||= @order.user.email if @order.user && @order.user.changed?
+      @order.email ||= @order.user.email if @order&.user&.changed?
 
       if @order.save
         flash[:notice] = t(".success")

api/app/controllers/spree/api/addresses_controller.rb

@@ -15,11 +15,10 @@ def update
         authorize! :update, @order, order_token
         find_address
 
+        @address = @order.send(@order_source)
         if @order.update({"#{@order_source}_attributes" => address_params})
-          @address = @order.send(@order_source)
           respond_with(@address, default_template: :show)
         else
-          @address = @order.send(@order_source)
           invalid_resource!(@address)
         end
       end

api/app/controllers/spree/api/inventory_units_controller.rb

@@ -16,7 +16,7 @@ def update
         inventory_unit.transaction do
           if inventory_unit.update(inventory_unit_params)
             fire
-            render :show, status: 200
+            render :show, status: :ok
           else
             invalid_resource!(inventory_unit)
           end
@@ -30,14 +30,13 @@ def inventory_unit
       end
 
       def prepare_event
-        return unless @event = params[:fire]
+        @event = params[:fire]
+        return unless @event
 
         can_event = "can_#{@event}?"
 
-        unless inventory_unit.respond_to?(can_event) &&
-            inventory_unit.send(can_event)
-          render json: {exception: "cannot transition to #{@event}"},
-            status: 200
+        unless inventory_unit.respond_to?(can_event) && inventory_unit.send(can_event)
+          render json: {exception: "cannot transition to #{@event}"}, status: :ok
           false
         end
       end

api/app/controllers/spree/api/orders_controller.rb

@@ -91,7 +91,8 @@ def update
       end
 
       def current
-        if current_api_user && @order = current_api_user.last_incomplete_spree_order(store: current_store)
+        @order = current_api_user.last_incomplete_spree_order(store: current_store)
+        if current_api_user && @order
           respond_with(@order, default_template: :show, locals: {root_object: @order})
         else
           head :no_content
@@ -122,7 +123,7 @@ def order_params
       def prevent_customer_metadata_update
         return unless @order&.completed? && cannot?(:admin, Spree::Order)
 
-        params[:order].delete(:customer_metadata) if params[:order]
+        params[:order]&.delete(:customer_metadata)
       end
 
       def normalize_params

api/app/controllers/spree/api/products_controller.rb

@@ -133,7 +133,8 @@ def option_types_params
       end
 
       def set_up_shipping_category
-        if shipping_category = params[:product].delete(:shipping_category)
+        shipping_category = params[:product].delete(:shipping_category)
+        if shipping_category
           id = Spree::ShippingCategory.find_or_create_by(name: shipping_category).id
           params[:product][:shipping_category_id] = id
         end

api/lib/spree/api/engine.rb

@@ -10,7 +10,8 @@ class Engine < Rails::Engine
 
       # Leave initializer empty for backwards-compatibility. Other apps
       # might still rely on this event.
-      initializer "spree.api.environment", before: :load_config_initializers do; end
+      initializer "spree.api.environment", before: :load_config_initializers do
+      end
 
       config.after_initialize do
         Spree::Api::Config.check_load_defaults_called("Spree::Api::Config")