From 9e8458c8b3983d06796ac45dd3c5a946bc9f94fd Mon Sep 17 00:00:00 2001 From: nil-scan <54786157+nil-scan@users.noreply.github.com> Date: Fri, 31 Jan 2025 15:19:36 +1300 Subject: [PATCH 1/2] Change the log level to debug for cache traces (#576) --- changelog/v0.36.4/downgrade-log-level.yaml | 6 ++++++ pkg/api/v1/control-plane/cache/simple.go | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) create mode 100644 changelog/v0.36.4/downgrade-log-level.yaml diff --git a/changelog/v0.36.4/downgrade-log-level.yaml b/changelog/v0.36.4/downgrade-log-level.yaml new file mode 100644 index 000000000..42c30cf4a --- /dev/null +++ b/changelog/v0.36.4/downgrade-log-level.yaml @@ -0,0 +1,6 @@ +changelog: +- type: FIX + issueLink: https://github.com/kgateway-dev/kgateway/issues/8626 + resolvesIssue: true + description: >- + Downgrade the level of message "respond open watch priority %d and index %d :%v with new version %q" to debug. diff --git a/pkg/api/v1/control-plane/cache/simple.go b/pkg/api/v1/control-plane/cache/simple.go index e1ee61610..529d62905 100644 --- a/pkg/api/v1/control-plane/cache/simple.go +++ b/pkg/api/v1/control-plane/cache/simple.go @@ -159,7 +159,7 @@ func (cache *snapshotCache) SetSnapshot(node string, snapshot Snapshot) { version := snapshot.GetResources(watch.Request.TypeUrl).Version if version != watch.Request.VersionInfo { if cache.log != nil { - cache.log.Infof("respond open watch priority %d and index %d :%v with new version %q", pi.Index, pi.Priority, watch.Request.ResourceNames, version) + cache.log.Debugf("respond open watch priority %d and index %d :%v with new version %q", pi.Index, pi.Priority, watch.Request.ResourceNames, version) } resources := snapshot.GetResources(watch.Request.TypeUrl).Items @@ -273,7 +273,7 @@ func (cache *snapshotCache) CreateWatch(request Request) (chan Response, func()) priority := info.watches.Add(ResponseWatch{Request: request, Response: value}) info.mu.Unlock() if cache.log != nil { - cache.log.Infof("open watch Priority Index %d and Element Index %d for %s%v from nodeID %q, version %q", + cache.log.Debugf("open watch Priority Index %d and Element Index %d for %s%v from nodeID %q, version %q", priority.Priority, priority.Index, request.TypeUrl, request.ResourceNames, nodeID, request.VersionInfo) } return value, cache.cancelWatch(nodeID, priority) From f293d79d896dbeaf9be6474dddd43aa43178ad8e Mon Sep 17 00:00:00 2001 From: Ryan Old Date: Thu, 13 Feb 2025 13:46:40 -0800 Subject: [PATCH 2/2] Move and adjusted changelog --- changelog/{v0.36.4 => v0.35.6}/downgrade-log-level.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) rename changelog/{v0.36.4 => v0.35.6}/downgrade-log-level.yaml (63%) diff --git a/changelog/v0.36.4/downgrade-log-level.yaml b/changelog/v0.35.6/downgrade-log-level.yaml similarity index 63% rename from changelog/v0.36.4/downgrade-log-level.yaml rename to changelog/v0.35.6/downgrade-log-level.yaml index 42c30cf4a..850c62e36 100644 --- a/changelog/v0.36.4/downgrade-log-level.yaml +++ b/changelog/v0.35.6/downgrade-log-level.yaml @@ -1,6 +1,6 @@ changelog: - type: FIX - issueLink: https://github.com/kgateway-dev/kgateway/issues/8626 - resolvesIssue: true + issueLink: https://github.com/solo-io/solo-projects/issues/7530 + resolvesIssue: false description: >- Downgrade the level of message "respond open watch priority %d and index %d :%v with new version %q" to debug.