Update event values order for exceptions

Author: Johan Steffner

raven/base.py

@@ -623,7 +623,7 @@ def _iter_frames(self, data):
             for frame in data['stacktrace']['frames']:
                 yield frame
         if 'exception' in data:
-            for frame in data['exception']['values'][0]['stacktrace']['frames']:
+            for frame in data['exception']['values'][-1]['stacktrace']['frames']:
                 yield frame
 
     def _successful_send(self):
@@ -655,9 +655,9 @@ def _log_failed_submission(self, data):
         """
         message = data.pop('message', '<no message value>')
         output = [message]
-        if 'exception' in data and 'stacktrace' in data['exception']['values'][0]:
+        if 'exception' in data and 'stacktrace' in data['exception']['values'][-1]:
             # try to reconstruct a reasonable version of the exception
-            for frame in data['exception']['values'][0]['stacktrace']['frames']:
+            for frame in data['exception']['values'][-1]['stacktrace']['frames']:
                 output.append('  File "%(fn)s", line %(lineno)s, in %(func)s' % {
                     'fn': frame.get('filename', 'unknown_filename'),
                     'lineno': frame.get('lineno', -1),

raven/events.py

@@ -78,7 +78,7 @@ class Exception(BaseEvent):
     name = 'exception'
 
     def to_string(self, data):
-        exc = data[self.name]['values'][0]
+        exc = data[self.name]['values'][-1]
         if exc['value']:
             return '%s: %s' % (exc['type'], exc['value'])
         return exc['type']
@@ -115,7 +115,7 @@ def capture(self, exc_info=None, **kwargs):
         values = []
         for exc_info in _chained_exceptions(exc_info):
             value = self._get_value(*exc_info)
-            values.append(value)
+            values.insert(0, value)
 
         return {
             'level': kwargs.get('level', logging.ERROR),

tests/base/tests.py

@@ -292,7 +292,7 @@ def test_exception_event(self):
         event = self.client.events.pop(0)
         self.assertEquals(event['message'], 'ValueError: foo')
         self.assertTrue('exception' in event)
-        exc = event['exception']['values'][0]
+        exc = event['exception']['values'][-1]
         self.assertEquals(exc['type'], 'ValueError')
         self.assertEquals(exc['value'], 'foo')
         self.assertEquals(exc['module'], ValueError.__module__)  # this differs in some Python versions
@@ -316,7 +316,7 @@ def test_exception_event_true_exc_info(self):
         event = self.client.events.pop(0)
         self.assertEquals(event['message'], 'ValueError: foo')
         self.assertTrue('exception' in event)
-        exc = event['exception']['values'][0]
+        exc = event['exception']['values'][-1]
         stacktrace = exc['stacktrace']
         self.assertEquals(len(stacktrace['frames']), 1)
         frame = stacktrace['frames'][0]
@@ -347,7 +347,7 @@ def test2():
         self.assertEquals(len(self.client.events), 1)
         event = self.client.events.pop(0)
         self.assertEquals(event['message'], 'DecoratorTestException')
-        exc = event['exception']['values'][0]
+        exc = event['exception']['values'][-1]
         self.assertEquals(exc['type'], 'DecoratorTestException')
         self.assertEquals(exc['module'], self.DecoratorTestException.__module__)
         stacktrace = exc['stacktrace']
@@ -382,7 +382,7 @@ def test4():
         self.assertEquals(len(self.client.events), 1)
         event = self.client.events.pop(0)
         self.assertEquals(event['message'], 'DecoratorTestException')
-        exc = event['exception']['values'][0]
+        exc = event['exception']['values'][-1]
         self.assertEquals(exc['type'], 'DecoratorTestException')
         self.assertEquals(exc['module'], self.DecoratorTestException.__module__)
         stacktrace = exc['stacktrace']
@@ -563,7 +563,7 @@ def test_marks_in_app_frames_for_exception(self):
         })
 
         event = client.events.pop(0)
-        frames = event['exception']['values'][0]['stacktrace']['frames']
+        frames = event['exception']['values'][-1]['stacktrace']['frames']
         assert frames[0]['in_app']
         assert not frames[1]['in_app']
         assert not frames[2]['in_app']

tests/contrib/bottle/tests.py

@@ -66,7 +66,7 @@ def test_error(self):
         event = self.raven.events.pop(0)
         assert 'exception' in event
 
-        exc = event['exception']['values'][0]
+        exc = event['exception']['values'][-1]
         self.assertEquals(exc['type'], 'ValueError')
 
     def test_captureException_captures_http(self):

tests/contrib/django/tests.py

@@ -156,7 +156,7 @@ def test_signal_integration(self):
         assert len(self.raven.events) == 1
         event = self.raven.events.pop(0)
         assert 'exception' in event
-        exc = event['exception']['values'][0]
+        exc = event['exception']['values'][-1]
         assert exc['type'] == 'TypeError'
         assert exc['value'], "int() argument must be a string or a number == not 'NoneType'"
         assert event['level'] == logging.ERROR
@@ -169,7 +169,7 @@ def test_view_exception(self):
         assert len(self.raven.events) == 1
         event = self.raven.events.pop(0)
         assert 'exception' in event
-        exc = event['exception']['values'][0]
+        exc = event['exception']['values'][-1]
         assert exc['type'] == 'Exception'
         assert exc['value'] == 'view exception'
         assert event['level'] == logging.ERROR
@@ -260,7 +260,7 @@ def test_request_middleware_exception(self):
             event = self.raven.events.pop(0)
 
             assert 'exception' in event
-            exc = event['exception']['values'][0]
+            exc = event['exception']['values'][-1]
             assert exc['type'] == 'ImportError'
             assert exc['value'] == 'request'
             assert event['level'] == logging.ERROR
@@ -276,7 +276,7 @@ def test_response_middlware_exception(self):
             event = self.raven.events.pop(0)
 
             assert 'exception' in event
-            exc = event['exception']['values'][0]
+            exc = event['exception']['values'][-1]
             assert exc['type'] == 'ImportError'
             assert exc['value'] == 'response'
             assert event['level'] == logging.ERROR
@@ -293,7 +293,7 @@ def test_broken_500_handler_with_middleware(self):
             event = self.raven.events.pop(0)
 
             assert 'exception' in event
-            exc = event['exception']['values'][0]
+            exc = event['exception']['values'][-1]
             assert exc['type'] == 'Exception'
             assert exc['value'] == 'view exception'
             assert event['level'] == logging.ERROR
@@ -302,7 +302,7 @@ def test_broken_500_handler_with_middleware(self):
             event = self.raven.events.pop(0)
 
             assert 'exception' in event
-            exc = event['exception']['values'][0]
+            exc = event['exception']['values'][-1]
             assert exc['type'] == 'ValueError'
             assert exc['value'] == 'handler500'
             assert event['level'] == logging.ERROR
@@ -316,7 +316,7 @@ def test_view_middleware_exception(self):
             event = self.raven.events.pop(0)
 
             assert 'exception' in event
-            exc = event['exception']['values'][0]
+            exc = event['exception']['values'][-1]
             assert exc['type'] == 'ImportError'
             assert exc['value'] == 'view'
             assert event['level'] == logging.ERROR
@@ -498,7 +498,7 @@ def test_marks_django_frames_correctly(self):
         assert len(self.raven.events) == 1
         event = self.raven.events.pop(0)
 
-        frames = event['exception']['values'][0]['stacktrace']['frames']
+        frames = event['exception']['values'][-1]['stacktrace']['frames']
         for frame in frames:
             if frame['module'].startswith('django.'):
                 assert frame.get('in_app') is False

tests/contrib/flask/tests.py

@@ -106,7 +106,7 @@ def test_error_handler(self):
         event = self.raven.events.pop(0)
 
         assert 'exception' in event
-        exc = event['exception']['values'][0]
+        exc = event['exception']['values'][-1]
         self.assertEquals(exc['type'], 'ValueError')
         self.assertEquals(exc['value'], 'hello world')
         self.assertEquals(event['level'], logging.ERROR)

tests/contrib/test_celery.py

@@ -26,7 +26,7 @@ def dummy_task(x, y):
         dummy_task.delay(1, 0)
         assert len(self.client.events) == 1
         event = self.client.events[0]
-        exception = event['exception']['values'][0]
+        exception = event['exception']['values'][-1]
         assert event['culprit'] == 'dummy_task'
         assert exception['type'] == 'ZeroDivisionError'
 

tests/contrib/webpy/tests.py

@@ -53,7 +53,7 @@ def test_get(self):
 
         event = self.store.events.pop()
         assert 'exception' in event
-        exc = event['exception']['values'][0]
+        exc = event['exception']['values'][-1]
         self.assertEquals(exc['type'], 'ValueError')
         self.assertEquals(exc['value'], 'That\'s what she said')
         self.assertEquals(event['message'], 'ValueError: That\'s what she said')

tests/events/tests.py

@@ -18,7 +18,7 @@ def transform_expected(self, expected):
     else:
         # Otherwise, we only report the first element.
         def transform_expected(self, expected):
-            return expected[:1]
+            return expected[-1:]
 
     def check_capture(self, expected):
         """
@@ -51,7 +51,7 @@ def test_nested(self):
             try:
                 raise KeyError()
             except Exception:
-                self.check_capture(['KeyError', 'ValueError'])
+                self.check_capture(['ValueError', 'KeyError'])
 
     def test_raise_from(self):
         try:
@@ -60,7 +60,7 @@ def test_raise_from(self):
             try:
                 six.raise_from(KeyError(), exc)
             except Exception:
-                self.check_capture(['KeyError', 'ValueError'])
+                self.check_capture(['ValueError', 'KeyError'])
 
     def test_raise_from_different(self):
         try:
@@ -69,7 +69,7 @@ def test_raise_from_different(self):
             try:
                 six.raise_from(KeyError(), TypeError())
             except Exception:
-                self.check_capture(['KeyError', 'TypeError'])
+                self.check_capture(['TypeError', 'KeyError'])
 
     def test_handles_self_referencing(self):
         try:
@@ -93,7 +93,7 @@ def test_handles_self_referencing(self):
                 try:
                     six.raise_from(exc, exc2)
                 except Exception:
-                    self.check_capture(['ValueError', 'KeyError'])
+                    self.check_capture(['KeyError', 'ValueError'])
             else:
                 pytest.fail()
         else:

tests/handlers/logbook/tests.py

@@ -81,7 +81,7 @@ def test_logger(self):
 
             self.assertEquals(event['message'], 'This is a test info with an exception')
             assert 'exception' in event
-            exc = event['exception']['values'][0]
+            exc = event['exception']['values'][-1]
             self.assertEquals(exc['type'], 'ValueError')
             self.assertEquals(exc['value'], 'This is a test ValueError')
             self.assertTrue('sentry.interfaces.Message' in event)

tests/handlers/logging/tests.py

@@ -134,7 +134,7 @@ def test_logger_exc_info(self):
 
         self.assertEqual(event['message'], 'This is a test info with an exception')
         assert 'exception' in event
-        exc = event['exception']['values'][0]
+        exc = event['exception']['values'][-1]
         self.assertEqual(exc['type'], 'ValueError')
         self.assertEqual(exc['value'], 'This is a test ValueError')
         self.assertTrue('sentry.interfaces.Message' in event)

tests/middleware/tests.py

@@ -93,7 +93,7 @@ def test_captures_error_in_iteration(self):
         event = self.client.events.pop(0)
 
         assert 'exception' in event
-        exc = event['exception']['values'][0]
+        exc = event['exception']['values'][-1]
         self.assertEquals(exc['type'], 'ValueError')
         self.assertEquals(exc['value'], 'hello world')
         self.assertEquals(event['level'], logging.ERROR)
@@ -140,7 +140,7 @@ def test_systemexit_is_captured(self):
         event = self.client.events.pop(0)
 
         assert 'exception' in event
-        exc = event['exception']['values'][0]
+        exc = event['exception']['values'][-1]
         self.assertEquals(exc['type'], 'SystemExit')
         self.assertEquals(exc['value'], '1')
         self.assertEquals(event['level'], logging.ERROR)
@@ -160,7 +160,7 @@ def test_keyboard_interrupt_is_captured(self):
         event = self.client.events.pop(0)
 
         assert 'exception' in event
-        exc = event['exception']['values'][0]
+        exc = event['exception']['values'][-1]
         self.assertEquals(exc['type'], 'KeyboardInterrupt')
         self.assertEquals(exc['value'], '')
         self.assertEquals(event['level'], logging.ERROR)

tests/processors/tests.py

@@ -127,12 +127,12 @@ def test_stacktrace(self, *args, **kwargs):
         proc = SanitizePasswordsProcessor(Mock())
         result = proc.process(data)
 
-        # data['exception']['values'][0]['stacktrace']['frames'][0]['vars']
+        # data['exception']['values'][-1]['stacktrace']['frames'][0]['vars']
         self.assertTrue('exception' in result)
         exception = result['exception']
         self.assertTrue('values' in exception)
         values = exception['values']
-        stack = values[0]['stacktrace']
+        stack = values[-1]['stacktrace']
         self.assertTrue('frames' in stack)
 
         self.assertEquals(len(stack['frames']), 2)