From e5b7a4b17532b3e92da2e6d9e56d685cdd6a94df Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Javier=20Jime=CC=81nez=20Alvarez?=
 <javierjimenezalvarez@gmail.com>
Date: Fri, 26 Sep 2014 11:20:37 +0200
Subject: [PATCH] Views improvement for the controllers. Now, the view know how
 to deals with iterable values an date values.

---
 .../Resources/views/Audit/compare.html.twig   | 46 ++++++++-----------
 .../views/Audit/view_detail.html.twig         |  9 ++--
 2 files changed, 25 insertions(+), 30 deletions(-)

diff --git a/src/SimpleThings/EntityAudit/Resources/views/Audit/compare.html.twig b/src/SimpleThings/EntityAudit/Resources/views/Audit/compare.html.twig
index 5cd8baca..6d69be23 100644
--- a/src/SimpleThings/EntityAudit/Resources/views/Audit/compare.html.twig
+++ b/src/SimpleThings/EntityAudit/Resources/views/Audit/compare.html.twig
@@ -1,5 +1,21 @@
 {% extends "SimpleThingsEntityAuditBundle::layout.html.twig" %}
 
+{% macro showValue(value) %}
+    {% if value.timestamp is defined %}
+        {{ value|date('m/d/Y') }}
+    {% elseif value is iterable %}
+        <ul>
+        {% for element in value %}
+            <li>{{ element }}</li>
+        {% endfor %}
+        </ul>
+    {% else %}
+        {{ value }}
+    {% endif %}
+{% endmacro %}
+
+{% import _self as helper %}
+
 {% block simplethings_entityaudit_content %}
 <h1>Comparing {{ className }} with identifiers of {{ id }} between revisions {{ oldRev }} and {{ newRev }}</h1>
 
@@ -15,37 +31,13 @@
     <tr>
         <td>{{ field }}</td>
         <td>
-            {% if value.old.timestamp is defined %}
-                {{ value.old|date('m/d/Y') }}
-            {% elseif value.old is iterable %}
-                {% for element in value.old %}
-                    {{ element }}
-                {% endfor %}
-            {% else %}
-                {{ value.old }}
-            {% endif %}
+            {{ helper.showValue(value.old) }}
         </td>
         <td>
-            {% if value.same.timestamp is defined %}
-                {{ value.same|date('m/d/Y') }}
-            {% elseif value.same is iterable %}
-                {% for element in value.same %}
-                    {{ element }}
-                {% endfor %}
-            {% else %}
-                {{ value.same }}
-            {% endif %}
+            {{ helper.showValue(value.same) }}
         </td>
         <td>
-            {% if value.new.timestamp is defined %}
-                {{ value.new|date('m/d/Y') }}
-            {% elseif value.new is iterable %}
-                {% for element in value.new %}
-                    {{ element }}
-                {% endfor %}
-            {% else %}
-                {{ value.new }}
-            {% endif %}
+            {{ helper.showValue(value.new) }}
         </td>
     </tr>
     {% endfor %}
diff --git a/src/SimpleThings/EntityAudit/Resources/views/Audit/view_detail.html.twig b/src/SimpleThings/EntityAudit/Resources/views/Audit/view_detail.html.twig
index ec34a4fd..a5a3369b 100644
--- a/src/SimpleThings/EntityAudit/Resources/views/Audit/view_detail.html.twig
+++ b/src/SimpleThings/EntityAudit/Resources/views/Audit/view_detail.html.twig
@@ -17,9 +17,11 @@
         <td>{{ value|date('m/d/Y') }}</td>
         {% elseif value is iterable %}
         <td>
-            {% for element in value %}
-                {{ element }}
-            {% endfor %}
+            <ul>
+                {% for element in value %}
+                    <li>{{ element }}</li>
+                {% endfor %}
+            </ul>
         </td>
         {% else %}
         <td>{{ value }}</td>
@@ -30,3 +32,4 @@
 </table>
 
 {% endblock simplethings_entityaudit_content %}
+