[Mellanox] Fix BMC import issue#27721
Open
stephenxs wants to merge 2 commits into
Open
Conversation
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
keboliu
approved these changes
Jun 4, 2026
Collaborator
Author
|
/azpw run |
Collaborator
|
Retrying failed(or canceled) jobs... |
Collaborator
|
Retrying failed(or canceled) stages in build 1130678: ✅Stage Build:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
After lazy BMC initialization (#26901),
from .bmc import BMClived only insideinitialize_components().initialize_bmc()still callsBMC.get_instance()in the chassis module scope, soBMCwas never defined there. That breaks BMC CLIs on OpenBMC platforms, for example:sudo show platform bmc summary→Error retrieving BMC information: name 'BMC' is not definedsudo show platform bmc eeprom→Error retrieving BMC EEPROM information: name 'BMC' is not definedThe import must run in the function that uses
BMC, while keeping lazy load so non-BMC platforms do not pull in BMC/Redfish at chassis import time.Work item tracking
How I did it
from .bmc import BMCfrominitialize_components()intoinitialize_bmc()inplatform/mellanox/mlnx-platform-api/sonic_platform/chassis.py.DeviceDataManager.is_platform_with_bmc()gate ininitialize_components()unchanged; only the import site moved.bmc.pyis still loaded only when BMC initialization runs on BMC-capable platforms.How to verify it
cd platform/mellanox/mlnx-platform-api pytest tests/test_chassis.py tests/test_bmc.py -vExpect BMC fields (manufacturer, model, serial, etc.), not name 'BMC' is not defined.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)