Skip to content

Commit f25aa22

Browse files
Fixing test failures
1 parent 54a6d63 commit f25aa22

File tree

1 file changed

+14
-13
lines changed

1 file changed

+14
-13
lines changed

tests/chassis_modules_test.py

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -726,25 +726,26 @@ def test_is_transition_timed_out_all_paths(self):
726726

727727
def test__mark_transition_clear_calls_ModuleBase(self):
728728
import config.chassis_modules as cm
729-
from config.chassis_modules import ModuleBase as MB
730-
with mock.patch("config.chassis_modules.ModuleBase", new_callable=lambda: MB) as m_mb, \
731-
mock.patch("config.chassis_modules._state_db_conn"):
732-
inst = m_mb.return_value
729+
with mock.patch("config.chassis_modules.ModuleBase") as mock_mb, \
730+
mock.patch("config.chassis_modules._state_db_conn") as mock_conn:
731+
mock_instance = mock_mb.return_value
732+
mock_instance.clear_module_state_transition.return_value = True
733733
cm._mark_transition_clear("DPU0")
734-
self.assertEqual(1, inst.mark_module_state_transition_clear.call_count)
735-
inst.mark_module_state_transition_clear.assert_called_with("DPU0")
734+
self.assertEqual(1, mock_instance.clear_module_state_transition.call_count)
735+
mock_instance.clear_module_state_transition.assert_called_with(mock_conn.return_value, "DPU0")
736736

737737
def test__transition_timed_out_delegates_and_returns(self):
738738
import config.chassis_modules as cm
739-
from config.chassis_modules import ModuleBase as MB
740-
with mock.patch("config.chassis_modules.ModuleBase", new_callable=lambda: MB) as m_mb, \
741-
mock.patch("config.chassis_modules._state_db_conn"):
742-
inst = m_mb.return_value
743-
inst.is_module_state_transition_timed_out.return_value = True
739+
with mock.patch("config.chassis_modules.ModuleBase") as mock_mb, \
740+
mock.patch("config.chassis_modules._state_db_conn") as mock_conn, \
741+
mock.patch("config.chassis_modules.TRANSITION_TIMEOUT") as mock_timeout:
742+
mock_instance = mock_mb.return_value
743+
mock_instance.is_module_state_transition_timed_out.return_value = True
744+
mock_timeout.total_seconds.return_value = 240
744745
out = cm._transition_timed_out("DPU0")
745746
self.assertTrue(out)
746-
self.assertEqual(1, inst.is_module_state_transition_timed_out.call_count)
747-
inst.is_module_state_transition_timed_out.assert_called_with("DPU0")
747+
self.assertEqual(1, mock_instance.is_module_state_transition_timed_out.call_count)
748+
mock_instance.is_module_state_transition_timed_out.assert_called_with(mock_conn.return_value, "DPU0", 240)
748749

749750
def test_shutdown_times_out_clears_and_messages(self):
750751
# Force the CLI path: transition in progress + timed out => clear + "Proceeding with shutdown."

0 commit comments

Comments
 (0)