FEC histogram with ability to clear stat #4075
Merged
+88
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
r12f
approved these changes
Oct 6, 2025
qiluo-msft
reviewed
Oct 6, 2025
| parser.add_argument('-D', '--delete-all', action='store_true', help='Delete all saved stats') | ||
| parser.add_argument('-e', '--errors', action='store_true', help='Display interface errors') | ||
| parser.add_argument('-f', '--fec-stats', action='store_true', help='Display FEC related statistics') | ||
| parser.add_argument('-fh', '--fec_hist', action='store_true', help='Display FEC histogram') |
There was a problem hiding this comment.
-fh may lead to confusing. Linux convention is -fh == -f -h
mihirpat1
pushed a commit
to mihirpat1/sonic-utilities
that referenced
this pull request
Oct 6, 2025
prgeor
added a commit
that referenced
this pull request
Oct 7, 2025
* FEC histogram with ability to clear stat (#4075) * Removed extra new line * Correct sequence numbers in counter_bucket_dict * Using len(counter_bucket_dict) instead of BUCKET_NUM * Modified BUCKET_NUM to 66 and added FEC counter bin handling in cnstat_print * Added unit-test to improve code coverage * Fixed SA warning --------- Co-authored-by: Prince George <[email protected]>
|
hi @mihirpat1 , do you mind to help create a manual PR to 202412? |
|
hi @mihirpat1 , gently ping again. do you mind to help create a manual PR to 202412? |
@r12f Per my understanding, this is not planned for 202412. @prgeor Please correct me if I am wrong |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added new CLI "portstat -fh" for displaying the FEC histogram which accounts for clear counter by "portstat -c"
How I did it
Added new CLI