Migrate to Redux Toolkit part 7 (#2971)

* Migrate `evalStory` handler to Stories Saga

* Add Redux utils

Originally done in f1cf593.

Amended to fix some bugs with types.

---------

Co-authored-by: Lee Yi <[email protected]>

* Migrate some stories actions to use helper

Type errors will be fixed later.

* Migrate more stories actions to use helper

* Fix old reducer/actions helper compatibility issues

* Migrate new stories users handler to BackendSaga

Done to align with where the action creator is located.

* Migrate StoriesSaga to use helper

Original implementation in bbf4f09.

Adapted to match current state of codebase.

---------

Co-authored-by: Lee Yi <[email protected]>

* Fix tests

* Fix compile errors

Also added a TODO for a testing util.

* Remove unnecessary rootReducer creator

* Fix combineSagaHandlers

* Migrate SessionActions to use helper

Some are left unmigrated to preserve the readability of the diff.

* Remove old session types

* Update tests and non-related sagas

Only updated sagas that require a simple fix of the imported action
types. Remaining sagas will be done in a later commit.

* Fix SessionActions compatibility with ActionsHelper

* Comment out most of mock backend saga

To minimise potentially unnecessary development effort while pending
removal decision outcome. Only commented handlers that are incompatible
with the type changes.

* Fix SessionReducer tests

* Use action creator in components

Use the action creator instead of creating the action object manually to
enforce abstraction.

* Migrate BackendSaga to use new helpers

Intentionally done in a very specific way, mixing new and old code
styles, in order to keep the diff legible for such a large migration.
Further refactoring will be done in the future.

* Update backend saga tests

* Remove duplicate action types

* Migrate mock backend to RTK action types

---------

Co-authored-by: Lee Yi <[email protected]>
Co-authored-by: En Rong <[email protected]>

Author: 3 people

src/commons/achievement/AchievementOverview.tsx

@@ -2,7 +2,7 @@ import React, { useEffect } from 'react';
 import { useDispatch } from 'react-redux';
 import { AchievementUser } from 'src/features/achievement/AchievementTypes';
 
-import { FETCH_TOTAL_XP, FETCH_TOTAL_XP_ADMIN } from '../application/types/SessionTypes';
+import { fetchTotalXp, fetchTotalXpAdmin } from '../application/actions/SessionActions';
 import { useTypedSelector } from '../utils/Hooks';
 import AchievementLevel from './overview/AchievementLevel';
 
@@ -20,9 +20,9 @@ const AchievementOverview: React.FC<Props> = ({ name, userState }) => {
   useEffect(() => {
     // If user is student, fetch assessment details from assessment route instead, as seen below
     if (crid && crid !== userCrid) {
-      dispatch({ type: FETCH_TOTAL_XP_ADMIN, payload: crid });
+      dispatch(fetchTotalXpAdmin(crid));
     } else {
-      dispatch({ type: FETCH_TOTAL_XP });
+      dispatch(fetchTotalXp());
     }
   }, [crid, userCrid, dispatch]);
 

src/commons/achievement/AchievementView.tsx

@@ -9,8 +9,12 @@ import {
   getAbilityGlow
 } from '../../features/achievement/AchievementConstants';
 import { AchievementStatus, AchievementUser } from '../../features/achievement/AchievementTypes';
-import { FETCH_ASSESSMENT, FETCH_ASSESSMENT_ADMIN } from '../application/types/SessionTypes';
-import { Assessment, FETCH_ASSESSMENT_OVERVIEWS } from '../assessment/AssessmentTypes';
+import {
+  fetchAssessment,
+  fetchAssessmentAdmin,
+  fetchAssessmentOverviews
+} from '../application/actions/SessionActions';
+import { Assessment } from '../assessment/AssessmentTypes';
 import { useTypedSelector } from '../utils/Hooks';
 import AchievementCommentCard from './AchievementCommentCard';
 import { prettifyDate } from './utils/DateHelper';
@@ -36,16 +40,17 @@ const AchievementView: React.FC<Props> = ({ focusUuid, userState }) => {
 
   const dispatch = useDispatch();
   useEffect(() => {
-    dispatch({ type: FETCH_ASSESSMENT_OVERVIEWS });
+    dispatch(fetchAssessmentOverviews());
     if (!assessmentId) {
       return;
     }
     if (isAdminView) {
       // Fetch selected user's assessment from admin route
-      dispatch({ type: FETCH_ASSESSMENT_ADMIN, payload: { assessmentId, courseRegId } });
+      // Safe to use non-null assertion (refer to `isAdminView` declaration above)
+      dispatch(fetchAssessmentAdmin(assessmentId, courseRegId!));
     } else {
       // If user is student, fetch assessment details from assessment route instead, as seen below
-      dispatch({ type: FETCH_ASSESSMENT, payload: { assessmentId } });
+      dispatch(fetchAssessment(assessmentId));
     }
   }, [dispatch, assessmentId, courseRegId, isAdminView]);