Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Commit 6b98c25

Browse files
eseligereseliger
authored
chore: Frontend does not need disk (#64273)
A long time ago, we dropped the requirement for frontend to have any disk for caching. Our helm deployments use read-only rootFSes, so this wouldn't even work. This PR aims to make that clearer by removing some last remnants of those times. Test plan: Frontend starts locally and integration tests pass in CI.
1 parent f19af57 commit 6b98c25

35 files changed

+419
-435
lines changed

‎cmd/frontend/image_test.yaml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,6 @@ commandTests:
1515
exitCode: 0
1616

1717
fileExistenceTests:
18-
- name: '/mnt/cache/frontend'
19-
path: '/mnt/cache/frontend'
20-
shouldExist: true
21-
uid: 100
22-
gid: 101
2318
- name: '/version.txt'
2419
path: '/version.txt'
2520
shouldExist: true

‎cmd/frontend/internal/cli/BUILD.bazel

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,6 @@ go_library(
9191
"@com_github_inconshreveable_log15//:log15",
9292
"@com_github_jackc_pgerrcode//:pgerrcode",
9393
"@com_github_keegancsmith_sqlf//:sqlf",
94-
"@com_github_keegancsmith_tmpfriend//:tmpfriend",
9594
"@com_github_kr_text//:text",
9695
"@com_github_nytimes_gziphandler//:gziphandler",
9796
"@com_github_prometheus_client_golang//prometheus",

‎cmd/frontend/internal/cli/serve_cmd.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import (
1313
"github.com/go-logr/stdr"
1414
"github.com/graph-gophers/graphql-go"
1515
"github.com/graph-gophers/graphql-go/relay"
16-
"github.com/keegancsmith/tmpfriend"
1716
sglog "github.com/sourcegraph/log"
1817
"github.com/throttled/throttled/v2"
1918
"github.com/throttled/throttled/v2/store/redigostore"
@@ -198,9 +197,6 @@ func Main(ctx context.Context, observationCtx *observation.Context, ready servic
198197

199198
printConfigValidation(logger)
200199

201-
cleanup := tmpfriend.SetupOrNOOP()
202-
defer cleanup()
203-
204200
// Don't proceed if system requirements are missing, to avoid
205201
// presenting users with a half-working experience.
206202
if err := checkSysReqs(context.Background(), os.Stderr); err != nil {

‎wolfi-images/appliance-frontend.lock.json

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -394,22 +394,22 @@
394394
},
395395
{
396396
"architecture": "x86_64",
397-
"checksum": "Q1F18C4nDz6+fzBYGQsKCBtHcufGU=",
397+
"checksum": "Q1Ih50BR1cw7C0mAoc5DuxT2LyzS4=",
398398
"control": {
399-
"checksum": "sha1-F18C4nDz6+fzBYGQsKCBtHcufGU=",
400-
"range": "bytes=701-1066"
399+
"checksum": "sha1-Ih50BR1cw7C0mAoc5DuxT2LyzS4=",
400+
"range": "bytes=702-1066"
401401
},
402402
"data": {
403-
"checksum": "sha256-WzeVjw8ROa6vrjTsCW005r5miWhaNGfwxi94+lfR1Xo=",
404-
"range": "bytes=1067-255911"
403+
"checksum": "sha256-2E9u6l5qsX+QONuHf29iItqZHbgx2aWN28a6u8/wFDM=",
404+
"range": "bytes=1067-261123"
405405
},
406406
"name": "c-ares",
407407
"signature": {
408-
"checksum": "sha1-pJet9qesYYyzB147oqQs+6X9fiA=",
409-
"range": "bytes=0-700"
408+
"checksum": "sha1-U8duAR/vdSu6louNZGpZtsHCooc=",
409+
"range": "bytes=0-701"
410410
},
411-
"url": "https://packages.wolfi.dev/os/x86_64/c-ares-1.32.3-r0.apk",
412-
"version": "1.32.3-r0"
411+
"url": "https://packages.wolfi.dev/os/x86_64/c-ares-1.33.0-r0.apk",
412+
"version": "1.33.0-r0"
413413
},
414414
{
415415
"architecture": "x86_64",
@@ -793,41 +793,41 @@
793793
},
794794
{
795795
"architecture": "x86_64",
796-
"checksum": "Q1Ba20KoIgLWqTMZ4Pbznhsk/TYRo=",
796+
"checksum": "Q185B6q4DzDD//zcCU0JWkkHxijsU=",
797797
"control": {
798-
"checksum": "sha1-Ba20KoIgLWqTMZ4Pbznhsk/TYRo=",
799-
"range": "bytes=703-1143"
798+
"checksum": "sha1-85B6q4DzDD//zcCU0JWkkHxijsU=",
799+
"range": "bytes=697-1139"
800800
},
801801
"data": {
802-
"checksum": "sha256-QHZujUhJ3AGy94XE+6XGYpGMFyM7tKOQB4syR9aiuGM=",
803-
"range": "bytes=1144-1342009"
802+
"checksum": "sha256-3PlDBSQN8HG1qDjQG53xk5k2DY+rhH/wnFF35621CPQ=",
803+
"range": "bytes=1140-1336085"
804804
},
805805
"name": "nginx-mainline",
806806
"signature": {
807-
"checksum": "sha1-Lstaj2vaaATxnhSfiZLcl2AFCnk=",
808-
"range": "bytes=0-702"
807+
"checksum": "sha1-3/vCsMg2DjoNChT4tJZcfraMR74=",
808+
"range": "bytes=0-696"
809809
},
810-
"url": "https://packages.wolfi.dev/os/x86_64/nginx-mainline-1.27.0-r6.apk",
811-
"version": "1.27.0-r6"
810+
"url": "https://packages.wolfi.dev/os/x86_64/nginx-mainline-1.27.0-r7.apk",
811+
"version": "1.27.0-r7"
812812
},
813813
{
814814
"architecture": "x86_64",
815-
"checksum": "Q1KMMgnvt16Z8QOgOaISyRx/kQi6A=",
815+
"checksum": "Q1y6S9bbDfFUw+0tN2VkqsAHWrbwM=",
816816
"control": {
817-
"checksum": "sha1-KMMgnvt16Z8QOgOaISyRx/kQi6A=",
818-
"range": "bytes=705-1090"
817+
"checksum": "sha1-y6S9bbDfFUw+0tN2VkqsAHWrbwM=",
818+
"range": "bytes=701-1086"
819819
},
820820
"data": {
821-
"checksum": "sha256-8ZAqh1Vl2VA4L3zPzGdNIaW8HOydRm1F4nq/vYfyehY=",
822-
"range": "bytes=1091-61920"
821+
"checksum": "sha256-CUzibd+CeRNExRfGogJAMyNBjNsVNZAMnLph6yw0iFU=",
822+
"range": "bytes=1087-61932"
823823
},
824824
"name": "nginx-mainline-config",
825825
"signature": {
826-
"checksum": "sha1-dksSmh2X/KWL+bmz31/sY8kkHeg=",
827-
"range": "bytes=0-704"
826+
"checksum": "sha1-azckUqdwF6E8PovL9nEUsWesYFQ=",
827+
"range": "bytes=0-700"
828828
},
829-
"url": "https://packages.wolfi.dev/os/x86_64/nginx-mainline-config-1.27.0-r6.apk",
830-
"version": "1.27.0-r6"
829+
"url": "https://packages.wolfi.dev/os/x86_64/nginx-mainline-config-1.27.0-r7.apk",
830+
"version": "1.27.0-r7"
831831
},
832832
{
833833
"architecture": "x86_64",
@@ -882,4 +882,4 @@
882882
]
883883
},
884884
"version": "v1"
885-
}
885+
}

‎wolfi-images/appliance.lock.json

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -394,22 +394,22 @@
394394
},
395395
{
396396
"architecture": "x86_64",
397-
"checksum": "Q1F18C4nDz6+fzBYGQsKCBtHcufGU=",
397+
"checksum": "Q1Ih50BR1cw7C0mAoc5DuxT2LyzS4=",
398398
"control": {
399-
"checksum": "sha1-F18C4nDz6+fzBYGQsKCBtHcufGU=",
400-
"range": "bytes=701-1066"
399+
"checksum": "sha1-Ih50BR1cw7C0mAoc5DuxT2LyzS4=",
400+
"range": "bytes=702-1066"
401401
},
402402
"data": {
403-
"checksum": "sha256-WzeVjw8ROa6vrjTsCW005r5miWhaNGfwxi94+lfR1Xo=",
404-
"range": "bytes=1067-255911"
403+
"checksum": "sha256-2E9u6l5qsX+QONuHf29iItqZHbgx2aWN28a6u8/wFDM=",
404+
"range": "bytes=1067-261123"
405405
},
406406
"name": "c-ares",
407407
"signature": {
408-
"checksum": "sha1-pJet9qesYYyzB147oqQs+6X9fiA=",
409-
"range": "bytes=0-700"
408+
"checksum": "sha1-U8duAR/vdSu6louNZGpZtsHCooc=",
409+
"range": "bytes=0-701"
410410
},
411-
"url": "https://packages.wolfi.dev/os/x86_64/c-ares-1.32.3-r0.apk",
412-
"version": "1.32.3-r0"
411+
"url": "https://packages.wolfi.dev/os/x86_64/c-ares-1.33.0-r0.apk",
412+
"version": "1.33.0-r0"
413413
},
414414
{
415415
"architecture": "x86_64",
@@ -806,4 +806,4 @@
806806
]
807807
},
808808
"version": "v1"
809-
}
809+
}

‎wolfi-images/batcheshelper.lock.json

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -394,22 +394,22 @@
394394
},
395395
{
396396
"architecture": "x86_64",
397-
"checksum": "Q1F18C4nDz6+fzBYGQsKCBtHcufGU=",
397+
"checksum": "Q1Ih50BR1cw7C0mAoc5DuxT2LyzS4=",
398398
"control": {
399-
"checksum": "sha1-F18C4nDz6+fzBYGQsKCBtHcufGU=",
400-
"range": "bytes=701-1066"
399+
"checksum": "sha1-Ih50BR1cw7C0mAoc5DuxT2LyzS4=",
400+
"range": "bytes=702-1066"
401401
},
402402
"data": {
403-
"checksum": "sha256-WzeVjw8ROa6vrjTsCW005r5miWhaNGfwxi94+lfR1Xo=",
404-
"range": "bytes=1067-255911"
403+
"checksum": "sha256-2E9u6l5qsX+QONuHf29iItqZHbgx2aWN28a6u8/wFDM=",
404+
"range": "bytes=1067-261123"
405405
},
406406
"name": "c-ares",
407407
"signature": {
408-
"checksum": "sha1-pJet9qesYYyzB147oqQs+6X9fiA=",
409-
"range": "bytes=0-700"
408+
"checksum": "sha1-U8duAR/vdSu6louNZGpZtsHCooc=",
409+
"range": "bytes=0-701"
410410
},
411-
"url": "https://packages.wolfi.dev/os/x86_64/c-ares-1.32.3-r0.apk",
412-
"version": "1.32.3-r0"
411+
"url": "https://packages.wolfi.dev/os/x86_64/c-ares-1.33.0-r0.apk",
412+
"version": "1.33.0-r0"
413413
},
414414
{
415415
"architecture": "x86_64",
@@ -863,4 +863,4 @@
863863
]
864864
},
865865
"version": "v1"
866-
}
866+
}

‎wolfi-images/blobstore.lock.json

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -394,22 +394,22 @@
394394
},
395395
{
396396
"architecture": "x86_64",
397-
"checksum": "Q1F18C4nDz6+fzBYGQsKCBtHcufGU=",
397+
"checksum": "Q1Ih50BR1cw7C0mAoc5DuxT2LyzS4=",
398398
"control": {
399-
"checksum": "sha1-F18C4nDz6+fzBYGQsKCBtHcufGU=",
400-
"range": "bytes=701-1066"
399+
"checksum": "sha1-Ih50BR1cw7C0mAoc5DuxT2LyzS4=",
400+
"range": "bytes=702-1066"
401401
},
402402
"data": {
403-
"checksum": "sha256-WzeVjw8ROa6vrjTsCW005r5miWhaNGfwxi94+lfR1Xo=",
404-
"range": "bytes=1067-255911"
403+
"checksum": "sha256-2E9u6l5qsX+QONuHf29iItqZHbgx2aWN28a6u8/wFDM=",
404+
"range": "bytes=1067-261123"
405405
},
406406
"name": "c-ares",
407407
"signature": {
408-
"checksum": "sha1-pJet9qesYYyzB147oqQs+6X9fiA=",
409-
"range": "bytes=0-700"
408+
"checksum": "sha1-U8duAR/vdSu6louNZGpZtsHCooc=",
409+
"range": "bytes=0-701"
410410
},
411-
"url": "https://packages.wolfi.dev/os/x86_64/c-ares-1.32.3-r0.apk",
412-
"version": "1.32.3-r0"
411+
"url": "https://packages.wolfi.dev/os/x86_64/c-ares-1.33.0-r0.apk",
412+
"version": "1.33.0-r0"
413413
},
414414
{
415415
"architecture": "x86_64",
@@ -1148,4 +1148,4 @@
11481148
]
11491149
},
11501150
"version": "v1"
1151-
}
1151+
}

‎wolfi-images/bundled-executor.lock.json

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -394,22 +394,22 @@
394394
},
395395
{
396396
"architecture": "x86_64",
397-
"checksum": "Q1F18C4nDz6+fzBYGQsKCBtHcufGU=",
397+
"checksum": "Q1Ih50BR1cw7C0mAoc5DuxT2LyzS4=",
398398
"control": {
399-
"checksum": "sha1-F18C4nDz6+fzBYGQsKCBtHcufGU=",
400-
"range": "bytes=701-1066"
399+
"checksum": "sha1-Ih50BR1cw7C0mAoc5DuxT2LyzS4=",
400+
"range": "bytes=702-1066"
401401
},
402402
"data": {
403-
"checksum": "sha256-WzeVjw8ROa6vrjTsCW005r5miWhaNGfwxi94+lfR1Xo=",
404-
"range": "bytes=1067-255911"
403+
"checksum": "sha256-2E9u6l5qsX+QONuHf29iItqZHbgx2aWN28a6u8/wFDM=",
404+
"range": "bytes=1067-261123"
405405
},
406406
"name": "c-ares",
407407
"signature": {
408-
"checksum": "sha1-pJet9qesYYyzB147oqQs+6X9fiA=",
409-
"range": "bytes=0-700"
408+
"checksum": "sha1-U8duAR/vdSu6louNZGpZtsHCooc=",
409+
"range": "bytes=0-701"
410410
},
411-
"url": "https://packages.wolfi.dev/os/x86_64/c-ares-1.32.3-r0.apk",
412-
"version": "1.32.3-r0"
411+
"url": "https://packages.wolfi.dev/os/x86_64/c-ares-1.33.0-r0.apk",
412+
"version": "1.33.0-r0"
413413
},
414414
{
415415
"architecture": "x86_64",
@@ -1420,22 +1420,22 @@
14201420
},
14211421
{
14221422
"architecture": "x86_64",
1423-
"checksum": "Q1OE9Tcv5FRM2R59X1GeBqhBSjO2c=",
1423+
"checksum": "Q17AwlSdfIPxMYPPS/H4Ft9xLdBv8=",
14241424
"control": {
1425-
"checksum": "sha1-OE9Tcv5FRM2R59X1GeBqhBSjO2c=",
1426-
"range": "bytes=701-1083"
1425+
"checksum": "sha1-7AwlSdfIPxMYPPS/H4Ft9xLdBv8=",
1426+
"range": "bytes=698-1079"
14271427
},
14281428
"data": {
1429-
"checksum": "sha256-G20U3AWP68ABai8Co/Yw7FURY39/cGwhZlAe2G0C1cM=",
1430-
"range": "bytes=1084-10723002"
1429+
"checksum": "sha256-WcvhGP/A9DbHMOM0wm2DTicccPJyQ8y9lZv3N0Dxtyk=",
1430+
"range": "bytes=1080-10727154"
14311431
},
14321432
"name": "yq",
14331433
"signature": {
1434-
"checksum": "sha1-pLMmu1lquvuF098yf/9+Vbk33YU=",
1435-
"range": "bytes=0-700"
1434+
"checksum": "sha1-qs3jEJRLG+t7HyfBiz0KABM/FRg=",
1435+
"range": "bytes=0-697"
14361436
},
1437-
"url": "https://packages.wolfi.dev/os/x86_64/yq-4.44.2-r1.apk",
1438-
"version": "4.44.2-r1"
1437+
"url": "https://packages.wolfi.dev/os/x86_64/yq-4.44.3-r0.apk",
1438+
"version": "4.44.3-r0"
14391439
}
14401440
],
14411441
"repositories": [
@@ -1452,4 +1452,4 @@
14521452
]
14531453
},
14541454
"version": "v1"
1455-
}
1455+
}

‎wolfi-images/caddy.lock.json

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -394,22 +394,22 @@
394394
},
395395
{
396396
"architecture": "x86_64",
397-
"checksum": "Q1F18C4nDz6+fzBYGQsKCBtHcufGU=",
397+
"checksum": "Q1Ih50BR1cw7C0mAoc5DuxT2LyzS4=",
398398
"control": {
399-
"checksum": "sha1-F18C4nDz6+fzBYGQsKCBtHcufGU=",
400-
"range": "bytes=701-1066"
399+
"checksum": "sha1-Ih50BR1cw7C0mAoc5DuxT2LyzS4=",
400+
"range": "bytes=702-1066"
401401
},
402402
"data": {
403-
"checksum": "sha256-WzeVjw8ROa6vrjTsCW005r5miWhaNGfwxi94+lfR1Xo=",
404-
"range": "bytes=1067-255911"
403+
"checksum": "sha256-2E9u6l5qsX+QONuHf29iItqZHbgx2aWN28a6u8/wFDM=",
404+
"range": "bytes=1067-261123"
405405
},
406406
"name": "c-ares",
407407
"signature": {
408-
"checksum": "sha1-pJet9qesYYyzB147oqQs+6X9fiA=",
409-
"range": "bytes=0-700"
408+
"checksum": "sha1-U8duAR/vdSu6louNZGpZtsHCooc=",
409+
"range": "bytes=0-701"
410410
},
411-
"url": "https://packages.wolfi.dev/os/x86_64/c-ares-1.32.3-r0.apk",
412-
"version": "1.32.3-r0"
411+
"url": "https://packages.wolfi.dev/os/x86_64/c-ares-1.33.0-r0.apk",
412+
"version": "1.33.0-r0"
413413
},
414414
{
415415
"architecture": "x86_64",
@@ -825,4 +825,4 @@
825825
]
826826
},
827827
"version": "v1"
828-
}
828+
}

0 commit comments

Comments
 (0)