feat(search): Make search aware of perforce changelist id mapping (#63563)

https://linear.app/sourcegraph/issue/SPLF-116/perforce-searching-by-perforce-changelist-id

## Details
We have had requests from our customers using Perforce to be able to
search inside of a changelist id. For a commit sha we support doing this

```
context:global repo:^perforce-sgdev-org/rhia-depot-test$@345c17c` some text
```

But for perforce they want to do the same thing but with the change list
ids. Which would look like this

```
context:global repo:^perforce-sgdev-org/rhia-depot-test$@changelist/83732` some text
```

To support this, I am attempting to smartly detect when we should do a
DB round trip and look up the proper mapping. I built a simple heuristic
that is
1. Is perforce changelist mapping feature flag enabled
2. Is this a perforce repo?
3. Is the revision request a integer ?

This mapping is just a best effort, if it fails it just falls back on
current behavior.

We are doing with a syntax of `@changelist/CL_ID` instead of supporting
`@CL_ID` to future proof us. This lookup focuses on finding the mapping
in the DB but in the future we may want to pre-create these refs in the
db duing mapping of perforce CLs to git commits.

## Limitations
This works well in testing however, the repo name@changelist/rev we
return contains the sha

![image](https://github.com/sourcegraph/sourcegraph/assets/304410/a673b9bd-d11f-4b36-bd95-c21ab8a5c4af)


I investigated changing this but it would required a larger change in
resolving the stream results. While that would be nice to have, I
decided to keep this minimal for now and add that later if needed

## Test plan

<!-- REQUIRED; info at
https://docs-legacy.sourcegraph.com/dev/background-information/testing_principles
-->

## Changelog
- For perforce depots, support searching within a specific changelist by
specifying a ref like `context:global repo:^repo/name$@changelist/83854`

Author: mmanela

.vscode/settings.json

@@ -36,7 +36,6 @@
   "editor.formatOnSave": true,
   "go.useLanguageServer": true,
   "gopls": {
-    "build.allowImplicitNetworkAccess": true,
     "local": "github.com/sourcegraph/sourcegraph"
   },
   "npm.packageManager": "pnpm",

client/web/src/repo/commits/GitCommitNode.tsx

@@ -271,7 +271,7 @@ export const GitCommitNode: React.FunctionComponent<React.PropsWithChildren<GitC
 
     const treeCanonicalURL =
         isPerforceChangelistMappingEnabled() && isPerforceDepot
-            ? node.tree.canonicalURL.replace(node.oid, refID)
+            ? node.tree.canonicalURL.replace(node.oid, `changelist/${refID}`)
             : node.tree.canonicalURL
 
     const viewFilesCommitElement = node.tree && (

cmd/frontend/graphqlbackend/repository.go

@@ -5,6 +5,7 @@ import (
 	"fmt"
 	"net/url"
 	"strconv"
+	"strings"
 	"sync"
 	"time"
 
@@ -318,6 +319,8 @@ func (r *RepositoryResolver) Changelist(ctx context.Context, args *RepositoryCha
 		attribute.String("changelist", args.CID))
 	defer tr.EndWithErr(&err)
 
+	// Strip "changelist/" prefix if present since we will sometimes append it in the UI.
+	args.CID = strings.TrimPrefix(args.CID, "changelist/")
 	cid, err := strconv.ParseInt(args.CID, 10, 64)
 	if err != nil {
 		// NOTE: From the UI, the user may visit a URL like:

cmd/frontend/graphqlbackend/repository_test.go

@@ -111,6 +111,36 @@ func TestRepository_Changelist(t *testing.T) {
 							"canonicalURL": "/perforce.sgdev.org/gorilla/mux/-/changelist/123",
 "commit": {
 	"oid": "%s"
+}
+						}
+					}
+				}
+			`, exampleCommitSHA1),
+	})
+
+	RunTest(t, &Test{
+		Schema: mustParseGraphQLSchema(t, db),
+		Query: `
+				{
+					repository(name: "perforce.sgdev.org/gorilla/mux") {
+						changelist(cid: "changelist/123") {
+							cid
+							canonicalURL
+							commit {
+								oid
+							}
+						}
+					}
+				}
+			`,
+		ExpectedResult: fmt.Sprintf(`
+				{
+					"repository": {
+						"changelist": {
+							"cid": "123",
+							"canonicalURL": "/perforce.sgdev.org/gorilla/mux/-/changelist/123",
+"commit": {
+	"oid": "%s"
 }
 						}
 					}

internal/database/dbmocks/mocks_temp.go

@@ -22,9 +22,12 @@ type RepoCommitsChangelistsStore interface {
 	// GetLatestForRepo will return the latest commit that has been mapped in the database.
 	GetLatestForRepo(ctx context.Context, repoID api.RepoID) (*types.RepoCommit, error)
 
-	// GetRepoCommit will return the mathcing row from the table for the given repo ID and the
+	// GetRepoCommit will return the matching row from the table for the given repo ID and the
 	// given changelist ID.
 	GetRepoCommitChangelist(ctx context.Context, repoID api.RepoID, changelistID int64) (*types.RepoCommit, error)
+
+	// BatchGetRepoCommitChangelist bulk loads repo commits for given repo ids and changelistIds
+	BatchGetRepoCommitChangelist(ctx context.Context, rcs ...RepoChangelistIDs) (map[api.RepoID]map[int64]*types.RepoCommit, error)
 }
 
 type repoCommitsChangelistsStore struct {
@@ -119,3 +122,66 @@ func (s *repoCommitsChangelistsStore) GetRepoCommitChangelist(ctx context.Contex
 	}
 	return repoCommit, nil
 }
+
+type RepoChangelistIDs struct {
+	RepoID        api.RepoID
+	ChangelistIDs []int64
+}
+
+var getRepoCommitFmtBatchStr = `
+SELECT
+	id,
+	repo_id,
+	commit_sha,
+	perforce_changelist_id
+FROM
+	repo_commits_changelists
+WHERE
+	%s;
+`
+
+func (s *repoCommitsChangelistsStore) BatchGetRepoCommitChangelist(ctx context.Context, rcs ...RepoChangelistIDs) (map[api.RepoID]map[int64]*types.RepoCommit, error) {
+	res := make(map[api.RepoID]map[int64]*types.RepoCommit, len(rcs))
+	for _, rc := range rcs {
+		res[rc.RepoID] = make(map[int64]*types.RepoCommit, len(rc.ChangelistIDs))
+	}
+
+	var where []*sqlf.Query
+	for _, rc := range rcs {
+		changeListIdsLength := len(rc.ChangelistIDs)
+		if changeListIdsLength == 0 {
+			continue
+		}
+		items := make([]*sqlf.Query, changeListIdsLength)
+		for i, id := range rc.ChangelistIDs {
+			items[i] = sqlf.Sprintf("%d", id)
+		}
+		where = append(where, sqlf.Sprintf("(repo_id=%d AND perforce_changelist_id IN (%s))", rc.RepoID, sqlf.Join(items, ",")))
+	}
+
+	var whereClause *sqlf.Query
+	if len(where) > 0 {
+		whereClause = sqlf.Join(where, "\n OR ")
+	} else {
+		// If input has no changeList ids just return an empty result
+		return res, nil
+	}
+
+	q := sqlf.Sprintf(getRepoCommitFmtBatchStr, whereClause)
+
+	rows, err := s.Query(ctx, q)
+	if err != nil {
+		return nil, err
+	}
+	defer rows.Close()
+
+	for rows.Next() {
+		if repoCommit, err := scanRepoCommitRow(rows); err != nil {
+			return nil, err
+		} else {
+			res[repoCommit.RepoID][repoCommit.PerforceChangelistID] = repoCommit
+		}
+	}
+
+	return res, rows.Err()
+}