Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactorings/switch bug #236

Closed
imba-tjd opened this issue May 3, 2022 · 1 comment
Closed

refactorings/switch bug #236

imba-tjd opened this issue May 3, 2022 · 1 comment

Comments

@imba-tjd
Copy link

imba-tjd commented May 3, 2022

Issue description or question

See https://github.com/imba-tjd/viztracer/pull/1#discussion_r863781996 or https://github.com/imba-tjd/viztracer/pull/1/files/ba2327e2457254fdbbf41062be42b06e481ac96c#diff-d185ee100bb846a83bef32ff1f863d59342312116fc4a44c43a6298aa87f370eL158

It changed

if self.inst_type == "log_var":
    event = "instant"
elif self.inst_type == "log_number":
    event = "counter"

to

if self.inst_type == "log_number":
    event = "counter"
elif self.inst_type == "log_var":
    event = "instant"

which is meaningless.

@Hellebore
Copy link
Collaborator

Agreed that this isn't desired behaviour - we're tracking this here: #102

Closing this as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants