Skip to content

Commit db82afc

Browse files
authored
Merge pull request #746 from sourceryinstitute/issue-745-rename-co_reduce-operator-for-F2018
Fix using co_reduce(...operator=...) for F2018.
2 parents 3317b20 + 896f2dd commit db82afc

File tree

6 files changed

+20
-4
lines changed

6 files changed

+20
-4
lines changed

src/tests/regression/reported/CMakeLists.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
caf_compile_executable(co_reduce-factorial issue-172-wrong-co_reduce.f90)
2-
caf_compile_executable(co_reduce-factorial-int8 issue-172-wrong-co_reduce-int8.f90)
3-
caf_compile_executable(co_reduce-factorial-int64 issue-172-wrong-co_reduce-int64.f90)
1+
caf_compile_executable(co_reduce-factorial issue-172-wrong-co_reduce.F90)
2+
caf_compile_executable(co_reduce-factorial-int8 issue-172-wrong-co_reduce-int8.F90)
3+
caf_compile_executable(co_reduce-factorial-int64 issue-172-wrong-co_reduce-int64.F90)
44
caf_compile_executable(source-alloc-sync issue-243-source-allocation-no-sync.f90)
55
caf_compile_executable(convert-before-put issue-292-convert-type-before-put.f90)
66
caf_compile_executable(issue-422-send issue-422-send.F90)

src/tests/regression/reported/issue-172-wrong-co_reduce-int64.f90 renamed to src/tests/regression/reported/issue-172-wrong-co_reduce-int64.F90

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,11 @@ program co_reduce_factorial_int64
1313
integer(kind=8) :: np
1414
value = this_image ( )
1515
np = num_images ( )
16+
#if defined(__GNUC__) && __GNUC__ < 12
1617
call co_reduce ( value, result_image = 1, operator = myProd )
18+
#else
19+
call co_reduce ( value, result_image = 1, operation = myProd )
20+
#endif
1721
!! value[k /= 1] undefined, value[ k == 1 ] should equal $n!$ where $n$ is `num_images()`
1822
if ( this_image ( ) == 1 ) then
1923
write ( * , '( "Number of images = ", g0 )' ) num_images ( )

src/tests/regression/reported/issue-172-wrong-co_reduce-int8.f90 renamed to src/tests/regression/reported/issue-172-wrong-co_reduce-int8.F90

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,11 @@ program co_reduce_factorial_int8
1313
integer(kind=1) :: np
1414
np = num_images ( )
1515
value = this_image ( )
16+
#if defined(__GNUC__) && __GNUC__ < 12
1617
call co_reduce ( value, result_image = 1, operator = myProd )
18+
#else
19+
call co_reduce ( value, result_image = 1, operation = myProd )
20+
#endif
1721
!! value[k /= 1] undefined, value[ k == 1 ] should equal $n!$ where $n$ is `num_images()`
1822
if ( this_image ( ) == 1 ) then
1923
write ( * , '( "Number of images = ", g0 )' ) num_images ( )

src/tests/regression/reported/issue-172-wrong-co_reduce.f90 renamed to src/tests/regression/reported/issue-172-wrong-co_reduce.F90

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,11 @@ program co_reduce_factorial
1111
integer :: value[ * ] !! Each image stores their image number here
1212
integer :: k
1313
value = this_image ( )
14+
#if defined(__GNUC__) && __GNUC__ < 12
1415
call co_reduce ( value, result_image = 1, operator = myProd )
16+
#else
17+
call co_reduce ( value, result_image = 1, operation = myProd )
18+
#endif
1519
!! value[k /= 1] undefined, value[ k == 1 ] should equal $n!$ where $n$ is `num_images()`
1620
if ( this_image ( ) == 1 ) then
1721
write ( * , '( "Number of images = ", g0 )' ) num_images ( )

src/tests/unit/collectives/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,5 @@ endif()
77
caf_compile_executable(co_min_test co_min.F90)
88
caf_compile_executable(co_max_test co_max.F90)
99
caf_compile_executable(co_reduce_test co_reduce.F90)
10-
caf_compile_executable(co_reduce_res_im co_reduce_res_im.f90)
10+
caf_compile_executable(co_reduce_res_im co_reduce_res_im.F90)
1111
caf_compile_executable(co_reduce_string co_reduce_string.f90)

src/tests/unit/collectives/co_reduce_res_im.f90 renamed to src/tests/unit/collectives/co_reduce_res_im.F90

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,11 @@ program co_reduce_res_im
1111
integer :: value[ * ] !! Each image stores their image number here
1212
integer :: k
1313
value = this_image ( )
14+
#if defined(__GNUC__) && __GNUC__ < 12
1415
call co_reduce ( value, result_image = 1, operator = myProd )
16+
#else
17+
call co_reduce ( value, result_image = 1, operation = myProd )
18+
#endif
1519
!! value[k /= 1] undefined, value[ k == 1 ] should equal $n!$ where $n$ is `num_images()`
1620
if ( this_image ( ) == 1 ) then
1721
write ( * , '( "Number of images = ", g0 )' ) num_images ( )

0 commit comments

Comments
 (0)