tests(mongodb): various fixes due to rector changes

Author: soyuka

features/hydra/docs.feature

@@ -63,7 +63,7 @@ Feature: Documentation support
     And "plainPassword" property is writable for Hydra class "User"
     And "plainPassword" property is not required for Hydra class "User"
     And the value of the node "@type" of the property "name" of the Hydra class "Dummy" is "hydra:SupportedProperty"
-    And the value of the node "hydra:property.@id" of the property "name" of the Hydra class "Dummy" is "http://schema.org/name"
+    And the value of the node "hydra:property.@id" of the property "name" of the Hydra class "Dummy" is "https://schema.org/name"
     And the value of the node "hydra:property.@type" of the property "name" of the Hydra class "Dummy" is "rdf:Property"
     And the value of the node "hydra:property.rdfs:label" of the property "name" of the Hydra class "Dummy" is "name"
     And the value of the node "hydra:property.domain" of the property "name" of the Hydra class "Dummy" is "#Dummy"

features/jsonld/context.feature

@@ -27,7 +27,7 @@ Feature: JSON-LD contexts generation
             "description": "https://schema.org/description",
             "dummy": "Dummy/dummy",
             "dummyBoolean": "Dummy/dummyBoolean",
-            "dummyDate": "http://schema.org/DateTime",
+            "dummyDate": "https://schema.org/DateTime",
             "dummyFloat": "Dummy/dummyFloat",
             "dummyPrice": "Dummy/dummyPrice",
             "relatedDummy": {
@@ -41,7 +41,7 @@ Feature: JSON-LD contexts generation
             "jsonData": "Dummy/jsonData",
             "arrayData": "Dummy/arrayData",
             "nameConverted": "Dummy/nameConverted",
-            "name": "http://schema.org/name",
+            "name": "https://schema.org/name",
             "alias": "https://schema.org/alternateName",
             "foo": "Dummy/foo"
         }

features/openapi/docs.feature

@@ -239,6 +239,7 @@ Feature: Documentation support
     Then the response status code should be 200
     And I should see text matching "openapi"
 
+  @!mongodb
   Scenario: Retrieve the OpenAPI documentation with API Gateway compatibility
     Given I send a "GET" request to "/docs.json?api_gateway=true"
     Then the response status code should be 200

src/Doctrine/Odm/Filter/ExistsFilter.php

@@ -53,7 +53,7 @@ public function __construct(ManagerRegistry $managerRegistry, LoggerInterface $l
      */
     public function apply(Builder $aggregationBuilder, string $resourceClass, Operation $operation = null, array &$context = []): void
     {
-        foreach ($context['filters'][$this->existsParameterName] as $property => $value) {
+        foreach ($context['filters'][$this->existsParameterName] ?? [] as $property => $value) {
             $this->filterProperty($this->denormalizePropertyName($property), $value, $aggregationBuilder, $resourceClass, $operation, $context);
         }
     }

tests/Fixtures/TestBundle/Controller/MongoDbOdm/DummyValidationController.php

@@ -21,7 +21,7 @@ class DummyValidationController
     /**
      * @param mixed $data
      */
-    #[Route(methods: ['POST'], name: 'post_validation_groups', path: '/dummy_validation/validation_groups', defaults: ['_api_resource_class' => DummyValidation::class, '_api_collection_operation_name' => 'post_validation_groups'])]
+    #[Route(methods: ['POST'], name: 'post_validation_groups', path: '/dummy_validation/validation_groups', defaults: ['_api_resource_class' => DummyValidation::class, '_api_operation_name' => 'post_validation_groups'])]
     public function postValidationGroups($data)
     {
         return $data;
@@ -30,7 +30,7 @@ public function postValidationGroups($data)
     /**
      * @param mixed $data
      */
-    #[Route(methods: ['POST'], name: 'post_validation_sequence', path: '/dummy_validation/validation_sequence', defaults: ['_api_resource_class' => DummyValidation::class, '_api_collection_operation_name' => 'post_validation_sequence'])]
+    #[Route(methods: ['POST'], name: 'post_validation_sequence', path: '/dummy_validation/validation_sequence', defaults: ['_api_resource_class' => DummyValidation::class, '_api_operation_name' => 'post_validation_sequence'])]
     public function postValidationSequence($data)
     {
         return $data;

tests/Fixtures/TestBundle/Document/Content.php

@@ -27,14 +27,14 @@ class Content implements \JsonSerializable
     #[ODM\Id(strategy: 'INCREMENT', type: 'int')]
     private ?int $id = null;
     #[ODM\Field(type: 'string')]
-    private ?string $contentType = null;
+    private string $contentType;
     /**
      * @var Collection<Field>
      */
     #[ODM\ReferenceMany(targetDocument: Field::class, mappedBy: 'content', strategy: 'set', cascade: ['persist'])]
     private \Doctrine\Common\Collections\Collection $fields;
     #[ODM\Field(type: 'string')]
-    private readonly string $status;
+    private string $status;
 
     public function __construct()
     {

tests/Fixtures/TestBundle/Document/CustomGeneratedIdentifier.php

@@ -14,7 +14,6 @@
 namespace ApiPlatform\Tests\Fixtures\TestBundle\Document;
 
 use ApiPlatform\Metadata\ApiResource;
-use ApiPlatform\Tests\Fixtures\TestBundle\Doctrine\Generator\Uuid;
 use Doctrine\ODM\MongoDB\Mapping\Annotations as ODM;
 
 /**
@@ -25,7 +24,7 @@
 class CustomGeneratedIdentifier
 {
     #[ODM\Id(strategy: 'CUSTOM', type: 'string', options: ['class' => \ApiPlatform\Tests\Fixtures\TestBundle\Doctrine\Generator\DocumentUuidGenerator::class])]
-    private ?Uuid $id = null;
+    private ?string $id = null;
 
     public function getId()
     {

tests/Fixtures/TestBundle/Document/Dummy.php

@@ -42,14 +42,14 @@ class Dummy
     /**
      * @var string|null The dummy name
      */
-    #[ApiProperty(types: ['http://schema.org/name'])]
+    #[ApiProperty(iris: ['https://schema.org/name'])]
     #[Assert\NotBlank]
     #[ODM\Field(type: 'string')]
     private $name;
     /**
      * @var string|null The dummy name alias
      */
-    #[ApiProperty(types: ['http://schema.org/alternateName'])]
+    #[ApiProperty(iris: ['https://schema.org/alternateName'])]
     #[ODM\Field(nullable: true)]
     private $alias;
     /**
@@ -59,7 +59,7 @@ class Dummy
     /**
      * @var string|null A short description of the item
      */
-    #[ApiProperty(types: ['http://schema.org/description'])]
+    #[ApiProperty(iris: ['https://schema.org/description'])]
     #[ODM\Field(type: 'string', nullable: true)]
     public $description;
     /**
@@ -75,7 +75,7 @@ class Dummy
     /**
      * @var \DateTime|null A dummy date
      */
-    #[ApiProperty(types: ['http://schema.org/DateTime'])]
+    #[ApiProperty(iris: ['https://schema.org/DateTime'])]
     #[ODM\Field(type: 'date', nullable: true)]
     public $dummyDate;
     /**

tests/Fixtures/TestBundle/Document/DummyCustomQuery.php

@@ -42,7 +42,7 @@
          ], name: 'testItemCustomArguments'),
      new QueryCollection(resolver: 'app.graphql.query_resolver.dummy_custom_collection', name: 'testCollection'),
      new QueryCollection(resolver: 'app.graphql.query_resolver.dummy_custom_collection_no_read_and_serialize', read: false, serialize: false, name: 'testCollectionNoReadAndSerialize'),
-     new Query(
+     new QueryCollection(
          name: 'testCollectionCustomArguments',
          resolver: 'app.graphql.query_resolver.dummy_custom_collection',
          args: ['customArgumentString' => ['type' => 'String!']]),

tests/Fixtures/TestBundle/Document/DummyDtoCustom.php

@@ -21,12 +21,25 @@
 use ApiPlatform\Metadata\Put;
 use ApiPlatform\Tests\Fixtures\TestBundle\Dto\CustomInputDto;
 use ApiPlatform\Tests\Fixtures\TestBundle\Dto\CustomOutputDto;
+use ApiPlatform\Tests\Fixtures\TestBundle\State\CustomInputDtoProcessor;
+use ApiPlatform\Tests\Fixtures\TestBundle\State\CustomOutputDtoProvider;
 use Doctrine\ODM\MongoDB\Mapping\Annotations as ODM;
 
 /**
  * DummyDtoCustom.
  */
-#[ApiResource(operations: [new Get(), new Get(output: CustomOutputDto::class, uriTemplate: 'dummy_dto_custom_output/{id}'), new Put(), new Delete(), new Post(input: CustomInputDto::class), new GetCollection(), new GetCollection(output: CustomOutputDto::class, uriTemplate: 'dummy_dto_custom_output'), new Post(output: false, uriTemplate: 'dummy_dto_custom_post_without_output')])]
+#[ApiResource(
+    operations: [
+        new Get(),
+        new Put(),
+        new Delete(),
+        new Post(input: CustomInputDto::class, processor: CustomInputDtoProcessor::class),
+        new GetCollection(),
+        new GetCollection(output: CustomOutputDto::class, uriTemplate: 'dummy_dto_custom_output', provider: CustomOutputDtoProvider::class),
+        new Get(output: CustomOutputDto::class, uriTemplate: 'dummy_dto_custom_output/{id}', provider: CustomOutputDtoProvider::class),
+        new Post(output: false, uriTemplate: 'dummy_dto_custom_post_without_output'),
+    ]
+)]
 #[ODM\Document]
 class DummyDtoCustom
 {

tests/Fixtures/TestBundle/Document/DummyDtoInputOutput.php

@@ -16,6 +16,8 @@
 use ApiPlatform\Metadata\ApiResource;
 use ApiPlatform\Tests\Fixtures\TestBundle\Dto\Document\InputDto;
 use ApiPlatform\Tests\Fixtures\TestBundle\Dto\Document\OutputDto;
+use ApiPlatform\Tests\Fixtures\TestBundle\State\DummyDtoInputOutputProcessor;
+use ApiPlatform\Tests\Fixtures\TestBundle\State\DummyDtoInputOutputProvider;
 use Doctrine\Common\Collections\ArrayCollection;
 use Doctrine\Common\Collections\Collection;
 use Doctrine\ODM\MongoDB\Mapping\Annotations as ODM;
@@ -25,7 +27,7 @@
  *
  * @author Kévin Dunglas <[email protected]>
  */
-#[ApiResource(input: InputDto::class, output: OutputDto::class)]
+#[ApiResource(input: InputDto::class, output: OutputDto::class, processor: DummyDtoInputOutputProcessor::class, provider: DummyDtoInputOutputProvider::class)]
 #[ODM\Document]
 class DummyDtoInputOutput
 {

tests/Fixtures/TestBundle/Document/DummyDtoNoInput.php

@@ -13,6 +13,7 @@
 
 namespace ApiPlatform\Tests\Fixtures\TestBundle\Document;
 
+use ApiPlatform\Doctrine\Odm\State\ItemProvider;
 use ApiPlatform\Metadata\ApiResource;
 use ApiPlatform\Metadata\Delete;
 use ApiPlatform\Metadata\Get;
@@ -21,14 +22,27 @@
 use ApiPlatform\Tests\Fixtures\TestBundle\Controller\DummyDtoNoInput\CreateItemAction;
 use ApiPlatform\Tests\Fixtures\TestBundle\Controller\DummyDtoNoInput\DoubleBatAction;
 use ApiPlatform\Tests\Fixtures\TestBundle\Dto\Document\OutputDto;
+use ApiPlatform\Tests\Fixtures\TestBundle\State\DummyDtoNoInputsProcessor;
+use ApiPlatform\Tests\Fixtures\TestBundle\State\DummyDtoNoInputsProvider;
 use Doctrine\ODM\MongoDB\Mapping\Annotations as ODM;
 
 /**
  * DummyDtoNoInput.
  *
  * @author Vincent Chalamon <[email protected]>
  */
-#[ApiResource(operations: [new Get(), new Delete(), new Post(uriTemplate: '/dummy_dto_no_inputs/{id}/double_bat', controller: DoubleBatAction::class, status: 200), new Post(uriTemplate: '/dummy_dto_no_inputs', controller: CreateItemAction::class), new GetCollection()], input: false, output: OutputDto::class)]
+#[ApiResource(
+    operations: [
+        new Get(),
+        new Delete(),
+        new Post(uriTemplate: '/dummy_dto_no_inputs/{id}/double_bat', controller: DoubleBatAction::class, status: 200, processor: DummyDtoNoInputsProcessor::class, output: DummyDtoNoInput::class, provider: ItemProvider::class),
+        new Post(uriTemplate: '/dummy_dto_no_inputs', controller: CreateItemAction::class, processor: DummyDtoNoInputsProcessor::class),
+        new GetCollection(),
+    ],
+    input: false,
+    output: OutputDto::class,
+    provider: DummyDtoNoInputsProvider::class
+)]
 #[ODM\Document]
 class DummyDtoNoInput
 {

tests/Fixtures/TestBundle/Document/DummyEntityWithConstructor.php

@@ -46,8 +46,8 @@ class DummyEntityWithConstructor
      * @param DummyObjectWithoutConstructor[] $items
      */
     public function __construct(
-        #[ODM\Field] private readonly string $foo,
-        #[ODM\Field] private readonly string $bar,
+        #[ODM\Field] private string $foo,
+        #[ODM\Field] private string $bar,
         private readonly array $items
     ) {
     }

tests/Fixtures/TestBundle/Document/DummyValidation.php

@@ -14,16 +14,18 @@
 namespace ApiPlatform\Tests\Fixtures\TestBundle\Document;
 
 use ApiPlatform\Metadata\ApiResource;
-use ApiPlatform\Metadata\Delete;
-use ApiPlatform\Metadata\Get;
 use ApiPlatform\Metadata\GetCollection;
-use ApiPlatform\Metadata\Patch;
 use ApiPlatform\Metadata\Post;
-use ApiPlatform\Metadata\Put;
 use Doctrine\ODM\MongoDB\Mapping\Annotations as ODM;
 use Symfony\Component\Validator\Constraints as Assert;
 
-#[ApiResource(operations: [new Get(), new Put(), new Patch(), new Delete(), new GetCollection(), new Post(uriTemplate: 'dummy_validation.{_format}'), new GetCollection(routeName: 'post_validation_groups', validationContext: ['groups' => ['a']]), new GetCollection(routeName: 'post_validation_sequence', validationContext: ['groups' => 'app.dummy_validation.group_generator'])])]
+#[ApiResource(operations: [
+    new GetCollection(),
+    new Post(uriTemplate: 'dummy_validation.{_format}'),
+    new Post(routeName: 'post_validation_groups', validationContext: ['groups' => ['a']]),
+    new Post(routeName: 'post_validation_sequence', validationContext: ['groups' => 'app.dummy_validation.group_generator']),
+]
+)]
 #[ODM\Document]
 class DummyValidation
 {

tests/Fixtures/TestBundle/Document/DummyWithEmbedManyOmittingTargetDocument.php

@@ -27,11 +27,12 @@ class DummyWithEmbedManyOmittingTargetDocument
      */
     #[ODM\Id(strategy: 'INCREMENT', type: 'int')]
     private ?int $id = null;
+
     /**
      * @var EmbeddableDummy[]|Collection
      */
     #[ODM\EmbedMany]
-    private readonly array|\Doctrine\Common\Collections\Collection $embeddedDummies;
+    private $embeddedDummies;
 
     public function __construct()
     {

tests/Fixtures/TestBundle/Document/InitializeInput.php

@@ -15,9 +15,10 @@
 
 use ApiPlatform\Metadata\ApiResource;
 use ApiPlatform\Tests\Fixtures\TestBundle\Dto\InitializeInputDto;
+use ApiPlatform\Tests\Fixtures\TestBundle\State\InitializeInputProcessor;
 use Doctrine\ODM\MongoDB\Mapping\Annotations as ODM;
 
-#[ApiResource(input: InitializeInputDto::class)]
+#[ApiResource(input: InitializeInputDto::class, processor: InitializeInputProcessor::class)]
 #[ODM\Document]
 class InitializeInput
 {

tests/Fixtures/TestBundle/Document/RPC.php

@@ -16,11 +16,12 @@
 use ApiPlatform\Metadata\ApiResource;
 use ApiPlatform\Metadata\Post;
 use ApiPlatform\Tests\Fixtures\TestBundle\Dto\RPCOutput;
+use ApiPlatform\Tests\Fixtures\TestBundle\State\RPCProcessor;
 
 /**
  * RPC-like resource.
  */
-#[ApiResource(operations: [new Post(status: 202, messenger: true, uriTemplate: 'rpc', output: false), new Post(status: 200, uriTemplate: 'rpc_output', output: RPCOutput::class)])]
+#[ApiResource(operations: [new Post(status: 202, messenger: true, uriTemplate: 'rpc', output: false), new Post(status: 200, uriTemplate: 'rpc_output', output: RPCOutput::class, processor: RPCProcessor::class)])]
 class RPC
 {
     /**

tests/Fixtures/TestBundle/Document/ReadableOnlyProperty.php

@@ -32,7 +32,7 @@ class ReadableOnlyProperty
      */
     #[ApiProperty(writable: false)]
     #[ODM\Field]
-    private readonly string $name;
+    private string $name;
 
     public function __construct()
     {

tests/Fixtures/TestBundle/Document/VoDummyCar.php

@@ -24,13 +24,13 @@
 class VoDummyCar extends VoDummyVehicle
 {
     /**
-     * @var VoDummyInspection[]|Collection
+     * @var Collection
      */
     #[Groups(['car_read', 'car_write'])]
     #[ODM\ReferenceMany(targetDocument: VoDummyInspection::class, mappedBy: 'car', cascade: ['persist'])]
-    private readonly array|\Doctrine\Common\Collections\Collection $inspections;
+    private Collection $inspections;
 
-    public function __construct(string $make, VoDummyInsuranceCompany $insuranceCompany, array $drivers, #[Groups(['car_read', 'car_write'])] #[ODM\Field(type: 'int')] private readonly int $mileage, #[Groups(['car_read', 'car_write'])] #[ODM\Field] private readonly string $bodyType = 'coupe')
+    public function __construct(string $make, VoDummyInsuranceCompany $insuranceCompany, array $drivers, #[Groups(['car_read', 'car_write'])] #[ODM\Field(type: 'int')] private int $mileage, #[Groups(['car_read', 'car_write'])] #[ODM\Field] private string $bodyType = 'coupe')
     {
         parent::__construct($make, $insuranceCompany, $drivers);
         $this->inspections = new ArrayCollection();

tests/Fixtures/TestBundle/Document/VoDummyInspection.php

@@ -27,7 +27,7 @@ class VoDummyInspection
     #[ODM\Field(type: 'date')]
     private \DateTime $performed;
 
-    public function __construct(#[Groups(['car_read', 'car_write', 'inspection_read', 'inspection_write'])] #[ODM\Field(type: 'bool')] private readonly bool $accepted, #[Groups(['inspection_read', 'inspection_write'])] #[ODM\ReferenceOne(targetDocument: VoDummyCar::class, inversedBy: 'inspections')] private readonly VoDummyCar $car, DateTime $performed = null, private readonly string $attributeWithoutConstructorEquivalent = '')
+    public function __construct(#[Groups(['car_read', 'car_write', 'inspection_read', 'inspection_write'])] #[ODM\Field(type: 'bool')] private bool $accepted, #[Groups(['inspection_read', 'inspection_write'])] #[ODM\ReferenceOne(targetDocument: VoDummyCar::class, inversedBy: 'inspections')] private VoDummyCar $car, DateTime $performed = null, private string $attributeWithoutConstructorEquivalent = '')
     {
         $this->performed = $performed ?: new DateTime();
     }

tests/Fixtures/TestBundle/Document/VoDummyVehicle.php

@@ -27,11 +27,11 @@ abstract class VoDummyVehicle
      */
     #[Groups(['car_read', 'car_write'])]
     #[ODM\ReferenceMany(targetDocument: VoDummyDriver::class, cascade: ['persist'])]
-    private \Doctrine\Common\Collections\Collection $drivers;
+    private Collection $drivers;
 
     public function __construct(
-        #[Groups(['car_read', 'car_write'])] #[ODM\Field] private readonly string $make,
-        #[Groups(['car_read', 'car_write'])] #[ODM\ReferenceOne(targetDocument: VoDummyInsuranceCompany::class, cascade: ['persist'])] private readonly VoDummyInsuranceCompany $insuranceCompany,
+        #[Groups(['car_read', 'car_write'])] #[ODM\Field] private string $make,
+        #[Groups(['car_read', 'car_write'])] #[ODM\ReferenceOne(targetDocument: VoDummyInsuranceCompany::class, cascade: ['persist'])] private VoDummyInsuranceCompany $insuranceCompany,
         array $drivers
     ) {
         $this->drivers = new ArrayCollection($drivers);

tests/Fixtures/TestBundle/Document/VoidPayment.php

@@ -24,7 +24,7 @@ class VoidPayment
     private ?int $id = null;
 
     public function __construct(
-        #[ODM\ReferenceOne(targetDocument: Payment::class, inversedBy: 'voidPayment')] private readonly Payment $payment
+        #[ODM\ReferenceOne(targetDocument: Payment::class, inversedBy: 'voidPayment')] private Payment $payment
     ) {
     }
 

tests/Fixtures/TestBundle/Entity/Dummy.php

@@ -43,7 +43,7 @@ class Dummy
     /**
      * @var string The dummy name
      */
-    #[ApiProperty(iris: ['http://schema.org/name'])]
+    #[ApiProperty(iris: ['https://schema.org/name'])]
     #[ORM\Column]
     #[Assert\NotBlank]
     private string $name;
@@ -82,7 +82,7 @@ class Dummy
     /**
      * @var \DateTime|null A dummy date
      */
-    #[ApiProperty(iris: ['http://schema.org/DateTime'])]
+    #[ApiProperty(iris: ['https://schema.org/DateTime'])]
     #[ORM\Column(type: 'datetime', nullable: true)]
     public $dummyDate;
 

tests/Fixtures/TestBundle/Entity/DummyCustomQuery.php

@@ -20,6 +20,8 @@
 
 /**
  * Dummy with custom GraphQL query resolvers.
+ *
+ * @author Lukas Lücke <[email protected]>
  */
 #[ORM\Entity]
 #[ApiResource(graphQlOperations: [

tests/Fixtures/TestBundle/State/CustomInputDtoProcessor.php

@@ -34,7 +34,7 @@ public function process($data, Operation $operation, array $uriVariables = [], a
         }
 
         /**
-         * @var \ApiPlatform\Tests\Fixtures\TestBundle\Entity\DummyDtoCustom
+         * @var \ApiPlatform\Tests\Fixtures\TestBundle\Entity\DummyDtoCustom|\ApiPlatform\Tests\Fixtures\TestBundle\Document\DummyDtoCustom
          */
         $resourceObject = $context[AbstractItemNormalizer::OBJECT_TO_POPULATE] ?? new $context['resource_class']();
         $resourceObject->lorem = $data->foo;