fix: retro-compatibility with bc flag

METADATA_BACKWARD_COMPATIBILITY_LAYER

Author: soyuka

features/graphql/authorization.feature

@@ -152,6 +152,7 @@ Feature: Authorization checking
     And the JSON node "data.securedDummy.relatedDummy" should exist
     And the JSON node "data.securedDummy.relatedDummy" should not be null
 
+  @v3
   @createSchema
   Scenario: A user can't access a secured collection relation
     Given there are 1 SecuredDummy objects owned by dunglas with related dummies
@@ -175,6 +176,7 @@ Feature: Authorization checking
     And the header "Content-Type" should be equal to "application/json"
     And the JSON node "data.securedDummy.relatedDummies" should be null
 
+  @v3
   Scenario: A user can't access a secured relation
     When I add "Authorization" header equal to "Basic ZHVuZ2xhczprZXZpbg=="
     And I send the following GraphQL request:
@@ -232,6 +234,7 @@ Feature: Authorization checking
     And the JSON node "errors[0].message" should be equal to "Access Denied."
     And the JSON node "data.relatedSecuredDummies" should be null
 
+  @v3
   Scenario: A user can access a secured collection relation
     When I add "Authorization" header equal to "Basic ZHVuZ2xhczprZXZpbg=="
     And I send the following GraphQL request:
@@ -253,6 +256,7 @@ Feature: Authorization checking
     And the header "Content-Type" should be equal to "application/json"
     And the JSON node "data.securedDummy.relatedSecuredDummies" should have 1 element
 
+  @v3
   Scenario: A user can access a secured relation
     When I add "Authorization" header equal to "Basic ZHVuZ2xhczprZXZpbg=="
     And I send the following GraphQL request:
@@ -271,6 +275,7 @@ Feature: Authorization checking
     And the JSON node "data.securedDummy.relatedSecuredDummy" should exist
     And the JSON node "data.securedDummy.relatedSecuredDummy" should not be null
 
+  @v3
   Scenario: A user can access a non-secured collection relation
     When I add "Authorization" header equal to "Basic ZHVuZ2xhczprZXZpbg=="
     And I send the following GraphQL request:
@@ -292,6 +297,7 @@ Feature: Authorization checking
     And the header "Content-Type" should be equal to "application/json"
     And the JSON node "data.securedDummy.publicRelatedSecuredDummies" should have 1 element
 
+  @v3
   Scenario: A user can access a non-secured relation
     When I add "Authorization" header equal to "Basic ZHVuZ2xhczprZXZpbg=="
     When I send the following GraphQL request:
@@ -382,6 +388,7 @@ Feature: Authorization checking
     And the response should be in JSON
     And the JSON node "data.securedDummies.edges[2].node.ownerOnlyProperty" should be equal to "it works"
 
+  @v3
   Scenario: An admin can't create a secured resource with an owner-only property if they won't be the owner
     When I add "Authorization" header equal to "Basic YWRtaW46a2l0dGVu"
     And I send the following GraphQL request:
@@ -465,6 +472,7 @@ Feature: Authorization checking
     And the JSON node "data.securedDummy.adminOnlyProperty" should exist
     And the JSON node "data.securedDummy.adminOnlyProperty" should not be null
 
+  @v3
   Scenario: A user can't see a secured admin-only property on an object they own
     When I add "Authorization" header equal to "Basic ZHVuZ2xhczprZXZpbg=="
     And I send the following GraphQL request:
@@ -527,6 +535,7 @@ Feature: Authorization checking
     And the response should be in JSON
     And the JSON node "data.securedDummy.ownerOnlyProperty" should be equal to the string "updated"
 
+  @v3
   Scenario: An admin can't see a secured owner-only property on an object they don't own
     When I add "Authorization" header equal to "Basic YWRtaW46a2l0dGVu"
     And I send the following GraphQL request:

features/graphql/mutation.feature

@@ -663,6 +663,7 @@ Feature: GraphQL mutation support
     And the JSON node "data.createDummyGroup.clientMutationId" should be equal to "myId"
 
   @createSchema
+  @v3
   Scenario: Use serialization groups with relations
     Given there is 1 dummy object with relatedDummy and its thirdLevel
     And there is a RelatedDummy with 2 friends

features/json/input_output.feature

@@ -7,6 +7,7 @@ Feature: JSON DTO input and output
     Given I add "Accept" header equal to "application/json"
     And I add "Content-Type" header equal to "application/json"
 
+  @createSchema
   Scenario: Request a password reset
     And I send a "POST" request to "/users/password_reset_request" with body:
     """
@@ -24,6 +25,7 @@ Feature: JSON DTO input and output
     }
     """
 
+  @createSchema
   Scenario: Request a password reset for a non-existent user
     And I send a "POST" request to "/users/password_reset_request" with body:
     """
@@ -35,3 +37,4 @@ Feature: JSON DTO input and output
     And the response should be in JSON
     And the header "Content-Type" should be equal to "application/problem+json; charset=utf-8"
     And the JSON node "detail" should be equal to "User does not exist."
+

features/main/attribute_resource.feature

@@ -4,6 +4,7 @@ Feature: Resource attributes
   I should be able to fetch data from a state provider
 
   @php8
+  @v3
   @!mysql
   @!mongodb
   Scenario: Retrieve a Resource collection
@@ -36,6 +37,7 @@ Feature: Resource attributes
     """
 
   @php8
+  @v3
   @!mysql
   @!mongodb
   Scenario: Retrieve the first resource 
@@ -56,6 +58,7 @@ Feature: Resource attributes
     """
 
   @php8
+  @v3
   @!mysql
   @!mongodb
   Scenario: Retrieve the aliased resource
@@ -78,6 +81,7 @@ Feature: Resource attributes
     """
 
   @php8
+  @v3
   @!mysql
   @!mongodb
   Scenario: Patch the aliased resource

features/main/crud.feature

@@ -560,6 +560,7 @@ Feature: Create-Retrieve-Update-Delete
     And the response should be empty
 
   @php8
+  @v3
   @createSchema
   Scenario: Create a resource ProcessorEntity
     When I add "Content-Type" header equal to "application/ld+json"
@@ -586,6 +587,7 @@ Feature: Create-Retrieve-Update-Delete
     """
 
   @php8
+  @v3
   Scenario: Create a resource ProviderEntity
     When I add "Content-Type" header equal to "application/ld+json"
     And I send a "POST" request to "/provider_entities" with body:
@@ -611,6 +613,7 @@ Feature: Create-Retrieve-Update-Delete
     """
 
   @php8
+  @v3
   Scenario: Get a collection of Provider Entities
     When I send a "GET" request to "/provider_entities"
     Then the response status code should be 200
@@ -635,6 +638,7 @@ Feature: Create-Retrieve-Update-Delete
     """
 
   @php8
+  @v3
   Scenario: Get a resource ProviderEntity
     When I send a "GET" request to "/provider_entities/1"
     Then the response status code should be 200

features/main/crud_uri_variables.feature

@@ -2,6 +2,7 @@ Feature: Uri Variables
 
   @createSchema
   @php8
+  @v3
   Scenario: Create a resource Company
     When I add "Content-Type" header equal to "application/ld+json"
     And I send a "POST" request to "/companies" with body:
@@ -28,6 +29,7 @@ Feature: Uri Variables
     """
 
   @php8
+  @v3
   Scenario: Create a second resource Company
     When I add "Content-Type" header equal to "application/ld+json"
     And I send a "POST" request to "/companies" with body:
@@ -39,6 +41,7 @@ Feature: Uri Variables
     Then the response status code should be 201
 
   @php8
+  @v3
   Scenario: Create first Employee
     When I add "Content-Type" header equal to "application/ld+json"
     And I send a "POST" request to "/employees" with body:
@@ -66,6 +69,7 @@ Feature: Uri Variables
     """
 
   @php8
+  @v3
   Scenario: Create second Employee
     When I add "Content-Type" header equal to "application/ld+json"
     And I send a "POST" request to "/employees" with body:
@@ -78,6 +82,7 @@ Feature: Uri Variables
     Then the response status code should be 201
 
   @php8
+  @v3
   Scenario: Create third Employee
     When I add "Content-Type" header equal to "application/ld+json"
     And I send a "POST" request to "/employees" with body:
@@ -90,6 +95,7 @@ Feature: Uri Variables
     Then the response status code should be 201
 
   @php8
+  @v3
   Scenario: Retrieve the collection of employees
     When I add "Content-Type" header equal to "application/ld+json"
     And I send a "GET" request to "/companies/2/employees"
@@ -152,6 +158,7 @@ Feature: Uri Variables
     And the JSON node "data.companies.edges[1].node.employees.edges[1].node.name" should be equal to "foo3"
 
   @php8
+  @v3
   Scenario: Retrieve the company of an employee
     When I add "Content-Type" header equal to "application/ld+json"
     And I send a "GET" request to "/employees/1/company"
@@ -171,6 +178,7 @@ Feature: Uri Variables
     """
 
   @php8
+  @v3
   Scenario: Retrieve an employee
     When I add "Content-Type" header equal to "application/ld+json"
     And I send a "GET" request to "/companies/1/employees/1"
@@ -190,6 +198,7 @@ Feature: Uri Variables
     """
 
   @php8
+  @v3
   Scenario: Trying to get an employee of wrong company
     When I add "Content-Type" header equal to "application/ld+json"
     And I send a "GET" request to "/companies/1/employees/2"

features/main/operation_resource.feature

@@ -4,6 +4,7 @@ Feature: Resource operations
   I should be able to persist data from a processor
 
   @php8
+  @v3
   @createSchema
   @!mongodb
   Scenario: Create an operation resource
@@ -19,6 +20,7 @@ Feature: Resource operations
     Then the response status code should be 201
 
   @php8
+  @v3
   @!mongodb
   Scenario: Patch an operation resource
     When I add "Content-Type" header equal to "application/merge-patch+json"
@@ -41,6 +43,7 @@ Feature: Resource operations
     """
 
   @php8
+  @v3
   @!mongodb
   Scenario: Update an operation resource
     When I add "Content-Type" header equal to "application/ld+json"

features/openapi/docs.feature

@@ -10,7 +10,8 @@ Feature: Documentation support
     And the response should be in JSON
     And the header "Content-Type" should be equal to "application/json; charset=utf-8"
     # Context
-    And the JSON node "openapi" should be equal to "3.1.0"
+    # And the JSON node "openapi" should be equal to "3.1.0"
+    And the JSON node "openapi" should be equal to "3.0.0"
     # Root properties
     And the JSON node "info.title" should be equal to "My Dummy API"
     And the JSON node "info.description" should contain "This is a test API."

src/Action/EntrypointAction.php

@@ -14,7 +14,7 @@
 namespace ApiPlatform\Action;
 
 use ApiPlatform\Api\Entrypoint;
-use ApiPlatform\Core\Metadata\Resource\Factory\ResourceNameCollectionFactoryInterface;
+use ApiPlatform\Metadata\Resource\Factory\ResourceNameCollectionFactoryInterface;
 
 /**
  * Generates the API entrypoint.

src/Api/Entrypoint.php

@@ -13,7 +13,7 @@
 
 namespace ApiPlatform\Api;
 
-use ApiPlatform\Core\Metadata\Resource\ResourceNameCollection;
+use ApiPlatform\Metadata\Resource\ResourceNameCollection;
 
 /**
  * The first path you will see in the API.

src/Api/IdentifiersExtractor.php

@@ -14,6 +14,7 @@
 namespace ApiPlatform\Api;
 
 use ApiPlatform\Core\Identifier\CompositeIdentifierParser;
+use ApiPlatform\Core\Metadata\Property\Factory\PropertyMetadataFactoryInterface as LegacyPropertyMetadataFactoryInterface;
 use ApiPlatform\Exception\RuntimeException;
 use ApiPlatform\Metadata\GraphQl\Operation as GraphQlOperation;
 use ApiPlatform\Metadata\Property\Factory\PropertyMetadataFactoryInterface;
@@ -33,10 +34,13 @@ final class IdentifiersExtractor implements IdentifiersExtractorInterface
     use ResourceClassInfoTrait;
 
     private $propertyNameCollectionFactory;
+    /**
+     * @var LegacyPropertyMetadataFactoryInterface|PropertyMetadataFactoryInterface
+     */
     private $propertyMetadataFactory;
     private $propertyAccessor;
 
-    public function __construct(ResourceMetadataCollectionFactoryInterface $resourceMetadataFactory, ResourceClassResolverInterface $resourceClassResolver, PropertyNameCollectionFactoryInterface $propertyNameCollectionFactory, PropertyMetadataFactoryInterface $propertyMetadataFactory, PropertyAccessorInterface $propertyAccessor = null)
+    public function __construct(ResourceMetadataCollectionFactoryInterface $resourceMetadataFactory, ResourceClassResolverInterface $resourceClassResolver, PropertyNameCollectionFactoryInterface $propertyNameCollectionFactory, $propertyMetadataFactory, PropertyAccessorInterface $propertyAccessor = null)
     {
         $this->resourceMetadataFactory = $resourceMetadataFactory;
         $this->resourceClassResolver = $resourceClassResolver;

src/Api/ResourceClassResolver.php

@@ -13,8 +13,8 @@
 
 namespace ApiPlatform\Api;
 
-use ApiPlatform\Core\Metadata\Resource\Factory\ResourceNameCollectionFactoryInterface;
 use ApiPlatform\Exception\InvalidArgumentException;
+use ApiPlatform\Metadata\Resource\Factory\ResourceNameCollectionFactoryInterface;
 use ApiPlatform\Util\ClassInfoTrait;
 
 /**

src/Api/UriVariablesConverter.php

@@ -13,6 +13,7 @@
 
 namespace ApiPlatform\Api;
 
+use ApiPlatform\Core\Metadata\Property\Factory\PropertyMetadataFactoryInterface as LegacyPropertyMetadataFactoryInterface;
 use ApiPlatform\Exception\InvalidUriVariableException;
 use ApiPlatform\Metadata\Link;
 use ApiPlatform\Metadata\Property\Factory\PropertyMetadataFactoryInterface;
@@ -26,14 +27,18 @@
  */
 final class UriVariablesConverter implements UriVariablesConverterInterface
 {
+    /**
+     * @var LegacyPropertyMetadataFactoryInterface|PropertyMetadataFactoryInterface
+     */
     private $propertyMetadataFactory;
     private $uriVariableTransformers;
     private $resourceMetadataCollectionFactory;
 
     /**
      * @param iterable<UriVariableTransformerInterface> $uriVariableTransformers
+     * @param mixed                                     $propertyMetadataFactory
      */
-    public function __construct(PropertyMetadataFactoryInterface $propertyMetadataFactory, ResourceMetadataCollectionFactoryInterface $resourceMetadataCollectionFactory, iterable $uriVariableTransformers)
+    public function __construct($propertyMetadataFactory, ResourceMetadataCollectionFactoryInterface $resourceMetadataCollectionFactory, iterable $uriVariableTransformers)
     {
         $this->propertyMetadataFactory = $propertyMetadataFactory;
         $this->uriVariableTransformers = $uriVariableTransformers;