retroactively hide stale tracked system/app volumes on Linux

Two follow-ups to the Linux volume filter:

- Expand is_nested_app_mount to match the root paths (/mnt/.ix-apps,
  /mnt/pool/ix-applications), not just their children.
- In volumes.list, when a tracked DB entry has no matching live volume
  (because the new filters skip it entirely — virtual fs, /sys/firmware,
  etc.), re-evaluate visibility by mount path and override the stale
  is_user_visible value that was persisted by earlier builds. This
  avoids needing a data migration.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: jamiepine

core/src/ops/volumes/list/query.rs

@@ -221,7 +221,16 @@ impl LibraryQuery for VolumeListQuery {
 						if tracked_vol.device_id == current_device_id && !tracked_vol.is_online {
 							continue;
 						}
-						volumes.push(tracked_vol.to_tracked_volume().to_offline_volume());
+						let mut offline_vol =
+							tracked_vol.to_tracked_volume().to_offline_volume();
+						// Re-apply current platform visibility rules so stale DB
+						// entries from earlier versions (which tracked everything)
+						// inherit newly-added filters without a data migration.
+						if should_hide_by_mount_path(&offline_vol.mount_point) {
+							offline_vol.is_user_visible = false;
+							offline_vol.auto_track_eligible = false;
+						}
+						volumes.push(offline_vol);
 					}
 				}
 
@@ -255,4 +264,18 @@ impl LibraryQuery for VolumeListQuery {
 	}
 }
 
+/// Re-evaluate whether a mount path should be hidden from the user based on
+/// current platform visibility rules. Used to retroactively hide tracked
+/// volumes whose DB entries were created before the filter rules existed.
+#[cfg(target_os = "linux")]
+fn should_hide_by_mount_path(mount_point: &std::path::Path) -> bool {
+	crate::volume::utils::is_system_mount_point(mount_point)
+		|| crate::volume::utils::is_nested_app_mount(mount_point)
+}
+
+#[cfg(not(target_os = "linux"))]
+fn should_hide_by_mount_path(_mount_point: &std::path::Path) -> bool {
+	false
+}
+
 crate::register_library_query!(VolumeListQuery, "volumes.list");

core/src/volume/utils.rs

@@ -145,12 +145,19 @@ pub fn is_system_mount_point(mount_point: &Path) -> bool {
 ///
 /// Catches Docker/Kubernetes layer mounts, snap packages, ZFS snapshot
 /// directories, and TrueNAS Scale's iX Apps (each app creates many
-/// nested ZFS datasets under `ix-applications/`).
+/// nested ZFS datasets under `ix-applications/` — and the root of that
+/// hierarchy itself should also be hidden).
 #[cfg(target_os = "linux")]
 pub fn is_nested_app_mount(mount_point: &Path) -> bool {
 	let path_str = mount_point.to_string_lossy();
-	path_str.contains("/.ix-apps/")
-		|| path_str.contains("/ix-applications/")
+
+	// Match root directories as well as anything under them
+	let is_under = |needle: &str| -> bool {
+		path_str.contains(&format!("/{needle}/")) || path_str.ends_with(&format!("/{needle}"))
+	};
+
+	is_under(".ix-apps")
+		|| is_under("ix-applications")
 		|| path_str.contains("/docker/overlay2/")
 		|| path_str.contains("/containerd/")
 		|| path_str.contains("/kubelet/")