Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: math_util C-extension refuses to build for numpy 2.x #272

Closed
pllim opened this issue May 15, 2024 · 1 comment · Fixed by #274
Closed

BLD: math_util C-extension refuses to build for numpy 2.x #272

pllim opened this issue May 15, 2024 · 1 comment · Fixed by #274
Labels

Comments

@pllim
Copy link
Contributor

pllim commented May 15, 2024

I noticed in both #271 and #268 that test_basic.py::test_math_util_inner1d SKIPPED happens whenever numpy 2.x is present. This implies that math_util C-extension is failing to build with numpy 2.x and spherical-geometry is silently falling back to Python implementations, if available.

I think you have to change your build requirement to use numpy 2.0 (up to you if you want to use RC2 or wait for stable release). Its ABI would be backward compatible with numpy 1.x up to a certain point. This means you can build with numpy 2.0 while still let users choose to use this package with numpy 1.x at runtime.

@pllim pllim added the bug label May 15, 2024
@pllim
Copy link
Contributor Author

pllim commented May 15, 2024

BTW you don't see the build failure in tox log because the log hides a lot of stuff. You can opt to turn on verbosity but that might pull in a lot of noise. The easier way might be to install numpy 2.0.rc2 from PyPI locally and then try to build this package locally outside of tox to see what is crashing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant