Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to re-import influence function file using a more recent WSS IFM, to fix RoC inconsistency #26

Open
mperrin opened this issue Jan 20, 2021 · 1 comment
Open

Need to re-import influence function file using a more recent WSS IFM, to fix RoC inconsistency #26

mperrin opened this issue Jan 20, 2021 · 1 comment
Assignees
@mperrin
Labels
bug Something isn't working

Comments

@mperrin
Copy link
Collaborator

mperrin commented Jan 20, 2021

As discovered & discussed in WFTP10, there was a sign error in Ball's IFM for RoC, which they fixed a couple years ago but which wasn't yet propagated to WebbPSF. We should fix that in a new IFM.

Relatedly there's also some slight rotation cross-term in the tip tilts for the segments; this could also be fixed once Scott makes an updated IFM replacement.

More generally, the import script and toolkit to generate the IFM should be added into the dev_utils folder.
@mperrin mperrin self-assigned this Jan 20, 2021
@mperrin mperrin added the bug Something isn't working label Jan 20, 2021
@mperrin
Copy link
Collaborator Author

mperrin commented Jan 20, 2021

Note, a hack fix for this was added to spacetelescope/webbpsf#392; but that's pretty much just a temporary work around for now in WFTP10.

@BradleySappington BradleySappington transferred this issue from spacetelescope/webbpsf Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mperrin mperrin

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mperrin