This discrepancy was due to the fact that we don't run make validate-notebooks in our Github Actions workflow.
We should add it to starfish-prod-ci.yml
Originally posted by @shachafl in #2195
make validate-notebooks checks if jupyter notebooks and corresponding python scripts are similar.
We should address two issues:
- Add
make validate-notebooks to starfish-prod-ci.yml under starfish-slow.
- For testing locally, move
ipynb_validate_targets from fast to slow testing suite.
Originally posted by @shachafl in #2195
make validate-notebookschecks if jupyter notebooks and corresponding python scripts are similar.We should address two issues:
make validate-notebookstostarfish-prod-ci.ymlunderstarfish-slow.ipynb_validate_targetsfromfasttoslowtesting suite.