Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change runDataActiveRun replicant empty state to null instead of undefined #141

Open
zoton2 opened this issue Jan 20, 2023 · 0 comments
Open
Labels

Comments

@zoton2
Copy link
Contributor

zoton2 commented Jan 20, 2023

Right now, the runDataActiveRun replicant having no run set is indicated by it being undefined. The issue is the generated type doesn't represent that, and the JSON schema is a bit unclear although it does work. I was thinking about doing this before but didn't, and not sure why. Maybe null isn't the right setting for a run not being set, but in NodeCG's case it's easier to work with. This would obviously be a breaking change so would be targeting a v3.x.x if I decided to go ahead with it.

@zoton2 zoton2 changed the title Change runDataActiveRun replicant empty state to null instead of undefined. Change runDataActiveRun replicant empty state to null instead of undefined Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant