Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to keep same team/player IDs when importing schedules/editing runs, add external IDs #98

Open
zoton2 opened this issue Feb 25, 2021 · 1 comment

Comments

@zoton2
Copy link
Contributor

zoton2 commented Feb 25, 2021

Something that must've been an oversight when I added support for it but only noticed now, if you import a schedule with an "external ID" set, we never attempt to keep the internal IDs for the teams/players even if they are identical. Some logic could be added to keep any IDs the same if the external ID for that run matches,

From my limited testing, this may also happens when you simply edit a run too?

@zoton2 zoton2 changed the title Attempt to keep same team/player IDs when importing schedules Attempt to keep same team/player IDs when importing schedules/editing runs Feb 25, 2021
@zoton2
Copy link
Contributor Author

zoton2 commented Mar 4, 2021

As an extension of this, adding an externalID to both teams and players should help this. Horaro would just have to be a hash based on information we have (similar to what I do already for the runs themselves if no external ID is found) although Oengus does have IDs that can be used for players at least.

@zoton2 zoton2 changed the title Attempt to keep same team/player IDs when importing schedules/editing runs Attempt to keep same team/player IDs when importing schedules/editing runs, add external Ids Mar 4, 2021
@zoton2 zoton2 changed the title Attempt to keep same team/player IDs when importing schedules/editing runs, add external Ids Attempt to keep same team/player IDs when importing schedules/editing runs, add external IDs Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant