Prefer raise SystemExit to sys.exit

Author: AA-Turner

sphinx/__main__.py

@@ -1,7 +1,5 @@
 """The Sphinx documentation toolchain."""
 
-import sys
-
 from sphinx.cmd.build import main
 
-sys.exit(main(sys.argv[1:]))
+raise SystemExit(main())

sphinx/cmd/build.py

@@ -316,4 +316,4 @@ def main(argv: List[str] = sys.argv[1:]) -> int:
 
 
 if __name__ == '__main__':
-    sys.exit(main(sys.argv[1:]))
+    raise SystemExit(main())

sphinx/cmd/quickstart.py

@@ -228,7 +228,7 @@ def ask_user(d: Dict[str, Any]) -> None:
         d['path'] = do_prompt(__('Please enter a new root path (or just Enter to exit)'),
                               '', is_path_or_empty)
         if not d['path']:
-            sys.exit(1)
+            raise SystemExit(1)
 
     if 'sep' not in d:
         print()
@@ -605,4 +605,4 @@ def main(argv: List[str] = sys.argv[1:]) -> int:
 
 
 if __name__ == '__main__':
-    sys.exit(main(sys.argv[1:]))
+    raise SystemExit(main())

sphinx/ext/apidoc.py

@@ -412,7 +412,7 @@ def main(argv: List[str] = sys.argv[1:]) -> int:
         args.suffix = args.suffix[1:]
     if not path.isdir(rootpath):
         print(__('%s is not a directory.') % rootpath, file=sys.stderr)
-        sys.exit(1)
+        raise SystemExit(1)
     if not args.dryrun:
         ensuredir(args.destdir)
     excludes = [path.abspath(exclude) for exclude in args.exclude_pattern]

sphinx/ext/intersphinx.py

@@ -649,7 +649,7 @@ def inspect_main(argv: List[str]) -> None:
         print("Print out an inventory file.\n"
               "Error: must specify local path or URL to an inventory file.",
               file=sys.stderr)
-        sys.exit(1)
+        raise SystemExit(1)
 
     class MockConfig:
         intersphinx_timeout: Optional[int] = None

tests/roots/test-ext-autosummary-recursive/package/module_importfail.py

@@ -1,4 +1,2 @@
-import sys
-
 # Fail module import in a catastrophic way
-sys.exit(1)
+raise SystemExit(1)

tests/roots/test-ext-autosummary/autosummary_importfail.py

@@ -1,4 +1,2 @@
-import sys
-
 # Fail module import in a catastrophic way
-sys.exit(1)
+raise SystemExit(1)