Merge pull request #72 from roxblnfk/feature/insert-default-values

Allow insert default values (empty dataset)

Author: wolfy-j

src/Driver/Compiler.php

@@ -155,6 +155,13 @@ protected function insertQuery(QueryParameters $params, Quoter $q, array $tokens
             $values[] = $this->value($params, $q, $value);
         }
 
+        if ($tokens['columns'] === []) {
+            return sprintf(
+                'INSERT INTO %s DEFAULT VALUES',
+                $this->name($params, $q, $tokens['table'], true)
+            );
+        }
+
         return sprintf(
             'INSERT INTO %s (%s) VALUES %s',
             $this->name($params, $q, $tokens['table'], true),

src/Driver/MySQL/MySQLCompiler.php

@@ -22,6 +22,24 @@
  */
 class MySQLCompiler extends Compiler implements CachingCompilerInterface
 {
+    /**
+     * @param QueryParameters $params
+     * @param Quoter          $q
+     * @param array           $tokens
+     * @return string
+     */
+    protected function insertQuery(QueryParameters $params, Quoter $q, array $tokens): string
+    {
+        if ($tokens['columns'] === []) {
+            return sprintf(
+                'INSERT INTO %s () VALUES ()',
+                $this->name($params, $q, $tokens['table'], true)
+            );
+        }
+
+        return parent::insertQuery($params, $q, $tokens);
+    }
+
     /**
      * {@inheritdoc}
      *

src/Driver/SQLite/SQLiteCompiler.php

@@ -65,6 +65,13 @@ protected function selectQuery(QueryParameters $params, Quoter $q, array $tokens
      */
     protected function insertQuery(QueryParameters $params, Quoter $q, array $tokens): string
     {
+        if ($tokens['columns'] === []) {
+            return sprintf(
+                'INSERT INTO %s DEFAULT VALUES',
+                $this->name($params, $q, $tokens['table'], true)
+            );
+        }
+
         // @todo possibly different statement for versions higher than 3.7.11
         if (count($tokens['values']) === 1) {
             return parent::insertQuery($params, $q, $tokens);

src/Query/InsertQuery.php

@@ -101,7 +101,7 @@ public function values($rowsets): InsertQuery
         }
 
         if ($rowsets === []) {
-            throw new BuilderException('Insert rowsets must not be empty');
+            return $this;
         }
 
         //Checking if provided set is array of multiple
@@ -122,19 +122,6 @@ public function values($rowsets): InsertQuery
         return $this;
     }
 
-    /**
-     * @param QueryParameters|null $parameters
-     * @return string
-     */
-    public function sqlStatement(QueryParameters $parameters = null): string
-    {
-        if ($this->values === []) {
-            throw new BuilderException('Insert rowsets must not be empty');
-        }
-
-        return parent::sqlStatement($parameters);
-    }
-
     /**
      * Run the query and return last insert id.
      *

tests/Database/Driver/MySQL/InsertQueryTest.php

@@ -18,4 +18,24 @@
 class InsertQueryTest extends \Spiral\Database\Tests\InsertQueryTest
 {
     public const DRIVER = 'mysql';
+
+    public function testCompileQueryDefaults(): void
+    {
+        $insert = $this->db()->insert('table')->values([]);
+
+        $this->assertSameQuery(
+            "INSERT INTO {table} () VALUES ()",
+            (string)$insert
+        );
+    }
+
+    public function testSimpleInsertEmptyDataset(): void
+    {
+        $insert = $this->database->insert()->into('table')->values([]);
+
+        $this->assertSameQuery(
+            "INSERT INTO {table} () VALUES ()",
+            $insert
+        );
+    }
 }

tests/Database/InsertQueryTest.php

@@ -38,20 +38,36 @@ public function testCompileQuery(): void
         );
     }
 
-    public function testSimpleInsert(): void
+    public function testCompileQueryDefaults(): void
     {
-        $insert = $this->database->insert()->into('table')->values(
-            [
-                'name' => 'Anton'
-            ]
+        $insert = $this->db()->insert('table')->values([]);
+
+        $this->assertSameQuery(
+            "INSERT INTO {table} DEFAULT VALUES",
+            (string)$insert
         );
+    }
+
+    public function testSimpleInsert(): void
+    {
+        $insert = $this->database->insert()->into('table')->values(['name' => 'Anton']);
 
         $this->assertSameQuery(
             'INSERT INTO {table} ({name}) VALUES (?)',
             $insert
         );
     }
 
+    public function testSimpleInsertEmptyDataset(): void
+    {
+        $insert = $this->database->insert()->into('table')->values([]);
+
+        $this->assertSameQuery(
+            "INSERT INTO {table} DEFAULT VALUES",
+            $insert
+        );
+    }
+
     public function testSimpleInsertWithStatesValues(): void
     {
         $insert = $this->database->insert()->into('table')

tests/docker-compose.yml

@@ -3,6 +3,7 @@ version: "3"
 services:
   sqlserver:
     image: mcr.microsoft.com/mssql/server:2019-latest
+    restart: always
     ports:
       - "11433:1433"
     environment: