Skip to content

Conversation

@samsonasik
Copy link
Contributor

Q A
QA? ✔️

This is part of dead code set list, remove unused public method parameter when class is final.

@samsonasik
Copy link
Contributor Author

Ready to merge 👍

@codecov
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.77%. Comparing base (aae7791) to head (a174dd0).
Report is 41 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1131   +/-   ##
=========================================
  Coverage     89.77%   89.77%           
  Complexity     6491     6491           
=========================================
  Files           853      854    +1     
  Lines         18446    18445    -1     
=========================================
  Hits          16559    16559           
+ Misses         1887     1886    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@roxblnfk roxblnfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't change public function signature in this way because it might be used in the userland with named arguments.

I think it's time to create a 4.x branch and start cleaning up unnecessary parameters and other deprecations in it. This aligns with our roadmap.

I will move your PR to 4.x once everything is prepared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants