Skip to content

Commit c898d02

Browse files
authored
infra: add a twine check before uploading to pypi (datafusion-contrib#183)
`twine check --strict` would have caught the lack of README Context: datafusion-contrib#172 (comment) Example, PyO3/maturin-action#166 (comment) ### Testing Github action run on my fork shows that `twine check` fails https://github.com/kevinjqliu/tpchgen-rs/actions/runs/17332990961 Because datafusion-contrib#182 has not been applied yet Tested locally, with and without fix from datafusion-contrib#182: ``` maturin sdist twine check --strict <.tar.gz> ``` ``` maturin build --release twine check --strict <.wheel> ```
2 parents 4a5f0f3 + bdae3ef commit c898d02

1 file changed

Lines changed: 8 additions & 0 deletions

File tree

.github/workflows/tpchgen-cli-publish-pypi.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,10 +139,18 @@ jobs:
139139
attestations: write # Used to generate artifact attestation
140140
steps:
141141
- uses: actions/download-artifact@v4
142+
143+
- name: Install twine
144+
run: pip install twine
145+
146+
- name: Check distributions with twine
147+
run: twine check --strict wheels-*/*
148+
142149
- name: Generate artifact attestation
143150
uses: actions/attest-build-provenance@v2
144151
with:
145152
subject-path: 'wheels-*/*'
153+
146154
- name: Publish to PyPI
147155
uses: PyO3/maturin-action@v1
148156
with:

0 commit comments

Comments
 (0)