Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a between(arr, lower, strict, upper, strict2) compute function #2393

Open
joseph-isaacs opened this issue Feb 17, 2025 · 0 comments
Open

Comments

@joseph-isaacs
Copy link
Member

Add a compute function to compute the range lower {< | <= } value {< | <=} upper where strict ==> <, and <=otherwise.

This compute function has the semantics of:

binary_boolean(
    &compare(&arr, lower, op1).unwrap(),
    &compare(&arr, upper, op2).unwrap(),
    BinaryOperator::And,
)

This has a large perf win of between 2 and 3x the above. This is due to the two comparisons and a binary and, possibly the double canonicalisation of arr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant