Merge pull request JanKaul#226 from JanKaul/fix-upgrade-format-version

fix format version upgrade

Author: JanKaul

iceberg-rust-spec/src/spec/table_metadata.rs

@@ -892,6 +892,15 @@ impl From<FormatVersion> for u8 {
     }
 }
 
+impl From<FormatVersion> for i32 {
+    fn from(value: FormatVersion) -> Self {
+        match value {
+            FormatVersion::V1 => 1,
+            FormatVersion::V2 => 2,
+        }
+    }
+}
+
 #[cfg(test)]
 mod tests {
 

iceberg-rust-spec/src/spec/view_metadata.rs

@@ -301,6 +301,14 @@ impl From<FormatVersion> for u8 {
     }
 }
 
+impl From<FormatVersion> for i32 {
+    fn from(value: FormatVersion) -> Self {
+        match value {
+            FormatVersion::V1 => 1,
+        }
+    }
+}
+
 #[derive(Debug, Serialize, Deserialize, PartialEq, Eq, Clone, Default, Builder, Getters)]
 #[serde(rename_all = "kebab-case")]
 /// Fields for the version 2 of the view metadata.

iceberg-rust/src/catalog/commit.rs

@@ -420,7 +420,7 @@ pub fn apply_table_updates(
     for update in updates {
         match update {
             TableUpdate::UpgradeFormatVersion { format_version } => {
-                if u8::from(metadata.format_version) == format_version as u8 {
+                if i32::from(metadata.format_version) == format_version {
                     return Ok(());
                 }
                 unimplemented!("Table format upgrade");
@@ -520,7 +520,7 @@ pub fn apply_view_updates<T: Materialization + 'static>(
     for update in updates {
         match update {
             ViewUpdate::UpgradeFormatVersion { format_version } => {
-                if u8::from(metadata.format_version.clone()) == format_version as u8 {
+                if i32::from(metadata.format_version.clone()) == format_version {
                     return Ok(());
                 }
                 unimplemented!("Upgrade of format version");