Skip to content

Commit f5d7d31

Browse files
JanKaulJan Kaul
authored andcommitted
Merge pull request JanKaul#224 from JanKaul/revert-223-more-context-for-unimplemented
Revert "provide more context for unimplemented macro"
2 parents 1d70d7a + b2f3dc1 commit f5d7d31

File tree

3 files changed

+6
-9
lines changed

3 files changed

+6
-9
lines changed

catalogs/iceberg-file-catalog/src/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -506,7 +506,7 @@ impl Catalog for FileCatalog {
506506
_identifier: Identifier,
507507
_metadata_location: &str,
508508
) -> Result<Table, IcebergError> {
509-
unimplemented!("Register table for file catalog")
509+
unimplemented!()
510510
}
511511
}
512512

iceberg-rust-spec/src/spec/values.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -670,7 +670,7 @@ impl Value {
670670
precision: 38,
671671
scale: dec.scale(),
672672
}),
673-
_ => unimplemented!("Datatype for value"),
673+
_ => unimplemented!(),
674674
}
675675
}
676676

@@ -698,7 +698,7 @@ impl Value {
698698
Value::String(any) => Box::new(any),
699699
Value::UUID(any) => Box::new(any),
700700
Value::Decimal(any) => Box::new(any),
701-
_ => unimplemented!("Value conversion to any"),
701+
_ => unimplemented!(),
702702
}
703703
}
704704

iceberg-rust/src/catalog/commit.rs

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -423,7 +423,7 @@ pub fn apply_table_updates(
423423
if u8::from(metadata.format_version) == format_version as u8 {
424424
return Ok(());
425425
}
426-
unimplemented!("Table format upgrade");
426+
unimplemented!();
427427
}
428428
TableUpdate::AssignUuid { uuid } => {
429429
metadata.table_uuid = Uuid::parse_str(&uuid)?;
@@ -519,11 +519,8 @@ pub fn apply_view_updates<T: Materialization + 'static>(
519519
) -> Result<(), Error> {
520520
for update in updates {
521521
match update {
522-
ViewUpdate::UpgradeFormatVersion { format_version } => {
523-
if u8::from(metadata.format_version.clone()) == format_version as u8 {
524-
return Ok(());
525-
}
526-
unimplemented!("Upgrade of format version");
522+
ViewUpdate::UpgradeFormatVersion { format_version: _ } => {
523+
unimplemented!();
527524
}
528525
ViewUpdate::AssignUuid { uuid } => {
529526
metadata.view_uuid = Uuid::parse_str(&uuid)?;

0 commit comments

Comments
 (0)