Polishing

Author: EmilianoSanchez

src/storages/inLocalStorage/MySegmentsCacheInLocal.ts

@@ -51,7 +51,7 @@ export class MySegmentsCacheInLocal extends AbstractMySegmentsCacheSync {
 
   getRegisteredSegments(): string[] {
     const registeredSegments: string[] = [];
-    for (let i = 0; i < this.storage.length; i++) {
+    for (let i = 0, len = this.storage.length; i < len; i++) {
       const segmentName = this.keys.extractSegmentName(this.storage.key(i)!);
       if (segmentName) registeredSegments.push(segmentName);
     }

src/storages/inLocalStorage/__tests__/MySegmentsCacheInLocal.spec.ts

@@ -1,6 +1,7 @@
 import { MySegmentsCacheInLocal } from '../MySegmentsCacheInLocal';
 import { KeyBuilderCS, myLargeSegmentsKeyBuilder } from '../../KeyBuilderCS';
 import { loggerMock } from '../../../logger/__tests__/sdkLogger.mock';
+import { IMySegmentsResponse } from '../../../dtos/types';
 
 test('SEGMENT CACHE / in LocalStorage', () => {
   const caches = [
@@ -22,11 +23,10 @@ test('SEGMENT CACHE / in LocalStorage', () => {
   });
 
   caches.forEach(cache => {
-    // @ts-expect-error
     cache.resetSegments({
       added: [],
       removed: ['mocked-segment']
-    });
+    } as IMySegmentsResponse);
 
     expect(cache.isInSegment('mocked-segment')).toBe(false);
     expect(cache.getRegisteredSegments()).toEqual(['mocked-segment-2']);

src/storages/types.ts

@@ -10,8 +10,8 @@ import { ISettings } from '../types';
  */
 export interface StorageAdapter {
   readonly length: number;
-  getItem(key: string): string | null;
   key(index: number): string | null;
+  getItem(key: string): string | null;
   removeItem(key: string): void;
   setItem(key: string, value: string): void;
 }