Removed properties if none in sender

Author: chillaq

splitio/api/impressions.py

@@ -30,16 +30,7 @@ def _build_bulk(impressions):
             {
                 'f': test_name,
                 'i': [
-                    {
-                        'k': impression.matching_key,
-                        't': impression.treatment,
-                        'm': impression.time,
-                        'c': impression.change_number,
-                        'r': impression.label,
-                        'b': impression.bucketing_key,
-                        'pt': impression.previous_time,
-                        'properties': impression.properties
-                    }
+                    ImpressionsAPIBase._filter_out_null_prop(impression)
                     for impression in imps
                 ]
             }
@@ -49,6 +40,30 @@ def _build_bulk(impressions):
             )
         ]
 
+    @staticmethod
+    def _filter_out_null_prop(impression):
+        if impression.properties == None:
+            return {
+                    'k': impression.matching_key,
+                    't': impression.treatment,
+                    'm': impression.time,
+                    'c': impression.change_number,
+                    'r': impression.label,
+                    'b': impression.bucketing_key,
+                    'pt': impression.previous_time
+                    }
+            
+        return {
+                'k': impression.matching_key,
+                't': impression.treatment,
+                'm': impression.time,
+                'c': impression.change_number,
+                'r': impression.label,
+                'b': impression.bucketing_key,
+                'pt': impression.previous_time,
+                'properties': impression.properties
+                }
+
     @staticmethod
     def _build_counters(counters):
         """

tests/api/test_impressions_api.py

@@ -22,12 +22,12 @@
     'f': 'f1',
     'i': [
         {'k': 'k1', 'b': 'b1', 't': 'on', 'r': 'l1', 'm': 321654, 'c': 123456, 'pt': None, 'properties': {"prop": "val"}},
-        {'k': 'k3', 'b': 'b1', 't': 'on', 'r': 'l1', 'm': 321654, 'c': 123456, 'pt': None, 'properties': None},
+        {'k': 'k3', 'b': 'b1', 't': 'on', 'r': 'l1', 'm': 321654, 'c': 123456, 'pt': None},
     ],
 }, {
     'f': 'f2',
     'i': [
-        {'k': 'k2', 'b': 'b1', 't': 'off', 'r': 'l1', 'm': 321654, 'c': 123456, 'pt': None, 'properties': None},
+        {'k': 'k2', 'b': 'b1', 't': 'off', 'r': 'l1', 'm': 321654, 'c': 123456, 'pt': None},
     ]
 }]