From 86bc908ed85a7b2e422ca3a4b5fcd323d3049ed0 Mon Sep 17 00:00:00 2001 From: Siddharth Khatsuriya <62132600+siddharth-khatsuriya@users.noreply.github.com> Date: Fri, 23 May 2025 12:07:31 +0530 Subject: [PATCH] Revert "feat: adding docs change validation step in reuseable CI (#390)" This reverts commit e30a82125a96eb0c8010c5c81b133e95106ee06b. --- .../workflows/reusable-build-test-release.yml | 44 ------------------- 1 file changed, 44 deletions(-) diff --git a/.github/workflows/reusable-build-test-release.yml b/.github/workflows/reusable-build-test-release.yml index a2536c06..a4f08eb7 100644 --- a/.github/workflows/reusable-build-test-release.yml +++ b/.github/workflows/reusable-build-test-release.yml @@ -321,44 +321,6 @@ jobs: splunk_version_list=$(echo '${{ steps.determine_splunk.outputs.matrixSplunk }}' | jq -r '.[].version') sc4s_version_list=$(echo '${{ steps.matrix.outputs.supportedSC4S }}' | jq -r '.[].version') echo -e "## Summary of Versions Used\n- **Splunk versions used:** (${splunk_version_list})\n- **SC4S versions used:** (${sc4s_version_list})\n- Browser: Chrome" >> "$GITHUB_STEP_SUMMARY" - - validate-docs-change: - runs-on: ubuntu-latest - container: - image: python:3.9 - outputs: - status: ${{ steps.validate.outputs.status }} - steps: - - uses: actions/checkout@v4 - with: - submodules: false - persist-credentials: false - - name: Installing requirements - run: | - pip install pip -U - pip install mkdocs==1.6.1 mkdocs-material==9.6.9 poetry - - name: validate - id: validate - run: | - if poetry run mkdocs build --strict; then - echo "status=success" >> "$GITHUB_OUTPUT" - echo "status :: success" - else - echo "status=failure" >> "$GITHUB_OUTPUT" - echo "status :: failure" - fi - - enforce-docs-checks: - runs-on: ubuntu-latest - needs: validate-docs-change - if: github.ref == 'refs/heads/main' || github.event_name == 'pull_request' - steps: - - name: Fail if validate-docs-change failed - run: | - if [ "${{ needs.validate-docs-change.outputs.status }}" == "failure" ]; then - exit 1 - fi - fossa-scan: runs-on: ubuntu-latest steps: @@ -2994,7 +2956,6 @@ jobs: - run-ucc-modinput-tests - run-ui-tests - validate-pr-title - - enforce-docs-checks runs-on: ubuntu-latest env: NEEDS: ${{ toJson(needs) }} @@ -3012,11 +2973,6 @@ jobs: echo "run-publish=false" >> "$GITHUB_OUTPUT" echo "Publish conditions are not met." fi - if ${{ github.base_ref == 'main' }} && ${{ needs.enforce-docs-checks.result != 'success' }}; - then - echo " There are documentation changes that break mkdocs deploy. please check validate-docs-change step." - exit 1 - fi publish: if: ${{ !cancelled() && needs.pre-publish.outputs.run-publish == 'true' && (github.event_name == 'push' || needs.validate-custom-version.result == 'success') }}