From 3801d1a17c708e09dec0451bec5c4d2c4787da10 Mon Sep 17 00:00:00 2001
From: Marian Zeis <13335743+marianfoo@users.noreply.github.com>
Date: Fri, 6 Dec 2024 23:03:10 +0100
Subject: [PATCH] fix: label not found if no annotations available (#670)

---
 .../src/controller/odata/MetadataHandlerV4.ts | 22 +++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/packages/ui5-cc-spreadsheetimporter/src/controller/odata/MetadataHandlerV4.ts b/packages/ui5-cc-spreadsheetimporter/src/controller/odata/MetadataHandlerV4.ts
index f986a4f7b..fb8d52fb5 100644
--- a/packages/ui5-cc-spreadsheetimporter/src/controller/odata/MetadataHandlerV4.ts
+++ b/packages/ui5-cc-spreadsheetimporter/src/controller/odata/MetadataHandlerV4.ts
@@ -81,6 +81,17 @@ export default class MetadataHandlerV4 extends MetadataHandler {
 					propertyObject.maxLength = propertyValue.$MaxLength;
 					listObject.set(propertyName, propertyObject);
 				}
+				// if no annotation is found, still try to add the property
+				if(!propertyLabel && !propertyName.startsWith("SAP__")){
+					let propertyObject: Property = {} as Property;
+					propertyObject.label = this.getLabel(annotations, properties, propertyName, propertyLabel, odataType);
+					if (!propertyObject.label) {
+						propertyObject.label = propertyName;
+					}
+					propertyObject.type = propertyValue.$Type;
+					propertyObject.maxLength = propertyValue.$MaxLength;
+					listObject.set(propertyName, propertyObject);
+				}
 			}
 		} else {
 			const propertiesFiltered = [];
@@ -102,6 +113,17 @@ export default class MetadataHandlerV4 extends MetadataHandler {
 					propertyObject.maxLength = propertyValue.$MaxLength;
 					listObject.set(propertyName, propertyObject);
 				}
+				// if no annotation is found, still try to add the property
+				if(!propertyLabel && !propertyName.startsWith("SAP__")){
+					let propertyObject: Property = {} as Property;
+					propertyObject.label = this.getLabel(annotations, properties, propertyName, propertyLabel, odataType);
+					if (!propertyObject.label) {
+						propertyObject.label = propertyName;
+					}
+					propertyObject.type = propertyValue.$Type;
+					propertyObject.maxLength = propertyValue.$MaxLength;
+					listObject.set(propertyName, propertyObject);
+				}
 			}
 		}