Skip to content

Commit 88d5c5f

Browse files
committed
Fix samples and README
1 parent 521ac48 commit 88d5c5f

File tree

3 files changed

+11
-10
lines changed

3 files changed

+11
-10
lines changed

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ Then spring.io project page is updated for newly released version.
8585
And in the end the milestone closed and specific Google Space notified about release (if `SPRING_RELEASE_CHAT_WEBHOOK_URL` secret is present in the repository).
8686

8787
#### Example of Release caller workflow:
88-
https://github.com/spring-io/spring-github-workflows/blob/29fd75ff06da2789a1fcd9b1732bf8bce4704fa6/samples/release.yml#L1-L25
88+
https://github.com/spring-io/spring-github-workflows/blob/29fd75ff06da2789a1fcd9b1732bf8bce4704fa6/samples/release-with-gradle.yml#L1-L25
8989

9090
Such a workflow must be on every branch which is supposed to be released via GitHub actions.
9191

@@ -122,7 +122,7 @@ The [spring-backport-issue.yml](.github/workflows/spring-backport-issue.yml) use
122122
See its documentation for labeling convention and respective GitHub events for calling this workflow.
123123

124124
#### Backport Issue caller workflow example:
125-
https://github.com/spring-io/spring-github-workflows/blob/78b29123a17655f019d800690cc906d692f836a9/samples/backport-issue.yml#L1-L16
125+
https://github.com/spring-io/spring-github-workflows/blob/521ac488abc90d961704030a9f7a0ea635dbddde/samples/backport-issue.yml#L1-L16
126126

127127
## Dependabot Support
128128

@@ -144,7 +144,7 @@ The `spring-merge-dependabot-pr` workflow does these modifications to the Depend
144144
The `mergeArguments` input of this workflow is applied to the `gh pr merge` command.
145145

146146
#### Dependabot merge pull request workflow example:
147-
https://github.com/spring-io/spring-github-workflows/blob/710bf1214450ffb9a4d3a1cfbe12755ed2d59edc/samples/merge-dependabot-pr.yml#L1-L14
147+
https://github.com/spring-io/spring-github-workflows/blob/521ac488abc90d961704030a9f7a0ea635dbddde/samples/merge-dependabot-pr.yml#L1-L13
148148

149149
## Automatic cherry-pick workflow
150150

@@ -181,7 +181,7 @@ This action is used in the `verify-staged` job of the release workflow.
181181

182182
## Gradle Init Scripts
183183

184-
The `[deployment-repository-init.gradle](utils/deployment-repository-init.gradle)` script adds a Maven repository for publishing artifacts into a local directory (`/deployment-repository`) via respective `publishAllPublicationsToDeploymentRepository` Gradle task.
184+
The [deployment-repository-init.gradle](utils/deployment-repository-init.gradle) script adds a Maven repository for publishing artifacts into a local directory (`/deployment-repository`) via respective `publishAllPublicationsToDeploymentRepository` Gradle task.
185185
Then [spring-io/artifactory-deploy-action](https://github.com/spring-io/artifactory-deploy-action) picks up those artifacts for uploading to the Artifactory.
186186
The Maven build does that via `deploy` goal and respective `-DaltDeploymentRepository=local::file:deployment-repository` CLI option.
187187

samples/ci-snapshot-maven.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,5 @@ jobs:
1010
build_snapshot:
1111
uses: spring-io/spring-github-workflows/.github/workflows/spring-artifactory-maven-snapshot.yml@main
1212
secrets:
13-
JF_ARTIFACTORY_SPRING: ${{ secrets.JF_ARTIFACTORY_SPRING }}
13+
ARTIFACTORY_USERNAME: ${{ secrets.ARTIFACTORY_USERNAME }}
14+
ARTIFACTORY_PASSWORD: ${{ secrets.ARTIFACTORY_PASSWORD }}

samples/release-with-gradle.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,15 @@ jobs:
1010
uses: spring-io/spring-github-workflows/.github/workflows/spring-artifactory-gradle-release.yml@main
1111
with:
1212
buildToolArgs: dist
13+
deployMilestoneToCentral: true
1314
secrets:
1415
GH_ACTIONS_REPO_TOKEN: ${{ secrets.GH_ACTIONS_REPO_TOKEN }}
1516
DEVELOCITY_ACCESS_KEY: ${{ secrets.DEVELOCITY_ACCESS_KEY }}
1617
JF_ARTIFACTORY_SPRING: ${{ secrets.JF_ARTIFACTORY_SPRING }}
1718
ARTIFACTORY_USERNAME: ${{ secrets.ARTIFACTORY_USERNAME }}
1819
ARTIFACTORY_PASSWORD: ${{ secrets.ARTIFACTORY_PASSWORD }}
19-
SPRING_RELEASE_SLACK_WEBHOOK_URL: ${{ secrets.SPRING_RELEASE_SLACK_WEBHOOK_URL }}
20-
OSSRH_S01_TOKEN_USERNAME: ${{ secrets.OSSRH_S01_TOKEN_USERNAME }}
21-
OSSRH_S01_TOKEN_PASSWORD: ${{ secrets.OSSRH_S01_TOKEN_PASSWORD }}
22-
OSSRH_STAGING_PROFILE_NAME: ${{ secrets.OSSRH_STAGING_PROFILE_NAME }}
20+
CENTRAL_TOKEN_USERNAME: ${{ secrets.CENTRAL_TOKEN_USERNAME }}
21+
CENTRAL_TOKEN_PASSWORD: ${{ secrets.CENTRAL_TOKEN_PASSWORD }}
2322
GPG_PASSPHRASE: ${{ secrets.GPG_PASSPHRASE }}
24-
GPG_PRIVATE_KEY: ${{ secrets.GPG_PRIVATE_KEY }}
23+
GPG_PRIVATE_KEY: ${{ secrets.GPG_PRIVATE_KEY }}
24+
SPRING_RELEASE_CHAT_WEBHOOK_URL: ${{ secrets.SPRING_RELEASE_GCHAT_WEBHOOK_URL }}

0 commit comments

Comments
 (0)