Skip to content

Commit cd3fc2f

Browse files
jonatan-ivanovtzolov
jonatan-ivanov
authored and
tzolov
committed
Change log level from DEBUG to INFO for ObservationHandlers
The features are disabled by default and users need to explicitly enable them. Probably it makes more sense to log on INFO level so that users don't need to change the log level if they use the default behavior of Spring Boot. See gh-3003 See gh-3127
1 parent 5d6bbd9 commit cd3fc2f

File tree

10 files changed

+19
-19
lines changed

10 files changed

+19
-19
lines changed

‎spring-ai-client-chat/src/main/java/org/springframework/ai/chat/client/observation/ChatClientPromptContentObservationHandler.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public class ChatClientPromptContentObservationHandler implements ObservationHan
4040

4141
@Override
4242
public void onStop(ChatClientObservationContext context) {
43-
logger.debug("Chat Client Prompt Content:\n{}", ObservabilityHelper.concatenateEntries(processPrompt(context)));
43+
logger.info("Chat Client Prompt Content:\n{}", ObservabilityHelper.concatenateEntries(processPrompt(context)));
4444
}
4545

4646
private Map<String, Object> processPrompt(ChatClientObservationContext context) {

‎spring-ai-client-chat/src/test/java/org/springframework/ai/chat/client/observation/ChatClientPromptContentObservationHandlerTests.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ void whenEmptyPromptThenOutputNothing(CapturedOutput output) {
6363
.build();
6464
this.observationHandler.onStop(context);
6565
assertThat(output).contains("""
66-
Chat Client Prompt Content:
66+
INFO o.s.a.c.c.o.ChatClientPromptContentObservationHandler -- Chat Client Prompt Content:
6767
[]
6868
""");
6969
}
@@ -75,7 +75,7 @@ void whenPromptWithTextThenOutputIt(CapturedOutput output) {
7575
.build();
7676
this.observationHandler.onStop(context);
7777
assertThat(output).contains("""
78-
Chat Client Prompt Content:
78+
INFO o.s.a.c.c.o.ChatClientPromptContentObservationHandler -- Chat Client Prompt Content:
7979
["user":"supercalifragilisticexpialidocious"]
8080
""");
8181
}
@@ -90,7 +90,7 @@ void whenPromptWithMessagesThenOutputIt(CapturedOutput output) {
9090
.build();
9191
this.observationHandler.onStop(context);
9292
assertThat(output).contains("""
93-
Chat Client Prompt Content:
93+
INFO o.s.a.c.c.o.ChatClientPromptContentObservationHandler -- Chat Client Prompt Content:
9494
["system":"you're a chimney sweep", "user":"supercalifragilisticexpialidocious"]
9595
""");
9696
}

‎spring-ai-model/src/main/java/org/springframework/ai/chat/observation/ChatModelCompletionObservationHandler.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public class ChatModelCompletionObservationHandler implements ObservationHandler
4040

4141
@Override
4242
public void onStop(ChatModelObservationContext context) {
43-
logger.debug("Chat Model Completion:\n{}", ObservabilityHelper.concatenateStrings(completion(context)));
43+
logger.info("Chat Model Completion:\n{}", ObservabilityHelper.concatenateStrings(completion(context)));
4444
}
4545

4646
private List<String> completion(ChatModelObservationContext context) {

‎spring-ai-model/src/main/java/org/springframework/ai/chat/observation/ChatModelPromptContentObservationHandler.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public class ChatModelPromptContentObservationHandler implements ObservationHand
4040

4141
@Override
4242
public void onStop(ChatModelObservationContext context) {
43-
logger.debug("Chat Model Prompt Content:\n{}", ObservabilityHelper.concatenateStrings(prompt(context)));
43+
logger.info("Chat Model Prompt Content:\n{}", ObservabilityHelper.concatenateStrings(prompt(context)));
4444
}
4545

4646
private List<String> prompt(ChatModelObservationContext context) {

‎spring-ai-model/src/main/java/org/springframework/ai/image/observation/ImageModelPromptContentObservationHandler.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public void onStop(ImageModelObservationContext context) {
4444
.getInstructions()
4545
.forEach(message -> promptMessagesJoiner.add("\"" + message.getText() + "\""));
4646

47-
logger.debug("Image Model Prompt Content:\n{}", promptMessagesJoiner);
47+
logger.info("Image Model Prompt Content:\n{}", promptMessagesJoiner);
4848
}
4949
}
5050

‎spring-ai-model/src/test/java/org/springframework/ai/chat/observation/ChatModelCompletionObservationHandlerTests.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ void whenEmptyResponseThenOutputNothing(CapturedOutput output) {
6666
.build();
6767
this.observationHandler.onStop(context);
6868
assertThat(output).contains("""
69-
Chat Model Completion:
69+
INFO o.s.a.c.o.ChatModelCompletionObservationHandler -- Chat Model Completion:
7070
[]
7171
""");
7272
}
@@ -80,7 +80,7 @@ void whenEmptyCompletionThenOutputNothing(CapturedOutput output) {
8080
context.setResponse(new ChatResponse(List.of(new Generation(new AssistantMessage("")))));
8181
this.observationHandler.onStop(context);
8282
assertThat(output).contains("""
83-
Chat Model Completion:
83+
INFO o.s.a.c.o.ChatModelCompletionObservationHandler -- Chat Model Completion:
8484
[]
8585
""");
8686
}
@@ -95,7 +95,7 @@ void whenCompletionWithTextThenOutputIt(CapturedOutput output) {
9595
new Generation(new AssistantMessage("seriously, say please")))));
9696
this.observationHandler.onStop(context);
9797
assertThat(output).contains("""
98-
Chat Model Completion:
98+
INFO o.s.a.c.o.ChatModelCompletionObservationHandler -- Chat Model Completion:
9999
["say please", "seriously, say please"]
100100
""");
101101
}

‎spring-ai-model/src/test/java/org/springframework/ai/chat/observation/ChatModelPromptContentObservationHandlerTests.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ void whenEmptyPromptThenOutputNothing(CapturedOutput output) {
6565
.build();
6666
this.observationHandler.onStop(context);
6767
assertThat(output).contains("""
68-
Chat Model Prompt Content:
68+
INFO o.s.a.c.o.ChatModelPromptContentObservationHandler -- Chat Model Prompt Content:
6969
[]
7070
""");
7171
}
@@ -78,7 +78,7 @@ void whenPromptWithTextThenOutputIt(CapturedOutput output) {
7878
.build();
7979
this.observationHandler.onStop(context);
8080
assertThat(output).contains("""
81-
Chat Model Prompt Content:
81+
INFO o.s.a.c.o.ChatModelPromptContentObservationHandler -- Chat Model Prompt Content:
8282
["supercalifragilisticexpialidocious"]
8383
""");
8484
}
@@ -94,7 +94,7 @@ void whenPromptWithMessagesThenOutputIt(CapturedOutput output) {
9494
.build();
9595
this.observationHandler.onStop(context);
9696
assertThat(output).contains("""
97-
Chat Model Prompt Content:
97+
INFO o.s.a.c.o.ChatModelPromptContentObservationHandler -- Chat Model Prompt Content:
9898
["you're a chimney sweep", "supercalifragilisticexpialidocious"]
9999
""");
100100
}

‎spring-ai-model/src/test/java/org/springframework/ai/image/observation/ImageModelPromptContentObservationHandlerTests.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ void whenEmptyPromptThenOutputNothing(CapturedOutput output) {
6464
.build();
6565
this.observationHandler.onStop(context);
6666
assertThat(output).contains("""
67-
Image Model Prompt Content:
67+
INFO o.s.a.i.o.ImageModelPromptContentObservationHandler -- Image Model Prompt Content:
6868
[""]
6969
""");
7070
}
@@ -78,7 +78,7 @@ void whenPromptWithTextThenOutputIt(CapturedOutput output) {
7878
.build();
7979
this.observationHandler.onStop(context);
8080
assertThat(output).contains("""
81-
Image Model Prompt Content:
81+
INFO o.s.a.i.o.ImageModelPromptContentObservationHandler -- Image Model Prompt Content:
8282
["supercalifragilisticexpialidocious"]
8383
""");
8484
}
@@ -94,7 +94,7 @@ void whenPromptWithMessagesThenOutputIt(CapturedOutput output) {
9494
.build();
9595
this.observationHandler.onStop(context);
9696
assertThat(output).contains("""
97-
Image Model Prompt Content:
97+
INFO o.s.a.i.o.ImageModelPromptContentObservationHandler -- Image Model Prompt Content:
9898
["you're a chimney sweep", "supercalifragilisticexpialidocious"]
9999
""");
100100
}

‎spring-ai-vector-store/src/main/java/org/springframework/ai/vectorstore/observation/VectorStoreQueryResponseObservationHandler.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public class VectorStoreQueryResponseObservationHandler implements ObservationHa
4040

4141
@Override
4242
public void onStop(VectorStoreObservationContext context) {
43-
logger.debug("Vector Store Query Response:\n{}", ObservabilityHelper.concatenateStrings(documents(context)));
43+
logger.info("Vector Store Query Response:\n{}", ObservabilityHelper.concatenateStrings(documents(context)));
4444
}
4545

4646
private List<String> documents(VectorStoreObservationContext context) {

‎spring-ai-vector-store/src/test/java/org/springframework/ai/vectorstore/observation/VectorStoreQueryResponseObservationHandlerTests.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ void whenEmptyQueryResponseThenOutputNothing(CapturedOutput output) {
5757
var context = VectorStoreObservationContext.builder("db", VectorStoreObservationContext.Operation.ADD).build();
5858
this.observationHandler.onStop(context);
5959
assertThat(output).contains("""
60-
Vector Store Query Response:
60+
INFO o.s.a.v.o.VectorStoreQueryResponseObservationHandler -- Vector Store Query Response:
6161
[]
6262
""");
6363
}
@@ -68,7 +68,7 @@ void whenNonEmptyQueryResponseThenOutputIt(CapturedOutput output) {
6868
context.setQueryResponse(List.of(new Document("doc1"), new Document("doc2")));
6969
this.observationHandler.onStop(context);
7070
assertThat(output).contains("""
71-
Vector Store Query Response:
71+
INFO o.s.a.v.o.VectorStoreQueryResponseObservationHandler -- Vector Store Query Response:
7272
["doc1", "doc2"]
7373
""");
7474
}

0 commit comments

Comments
 (0)