Skip to content

provide setters for the various SQL queries used in the JDBC persistence types #2981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joshlong opened this issue May 3, 2025 · 1 comment
Milestone

Comments

@joshlong
Copy link
Member

joshlong commented May 3, 2025

some of the queries that are only available as private final fields in the classes are incompatible with certain databases, like Oracle.

for example JdbcChatMemory uses a query with limit which wont work on Oracle.

There's no easy way to fix this short of copy-and-pasting the entire class and excluding Spring AI's solution. if you provide a few setters or make the queries constructor arguments, that would be sufficient to unblock

please do this for anything that uses JDBC

@markpollack markpollack added this to the 1.0.0-RC1 milestone May 3, 2025
@markpollack
Copy link
Member

This has been address, the refactoring to focus on JdbcChatMemoryRepository and there isn't an impl of JdbcChatMemory anymore. PR #3037 shows how we support multiple dialects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants